Last Comment Bug 705324 - Remove nsAXPCNativeCallContext::{GetRetValPtr,GetReturnValueWasSet,SetReturnValueWasSet}
: Remove nsAXPCNativeCallContext::{GetRetValPtr,GetReturnValueWasSet,SetReturnV...
Status: RESOLVED FIXED
: meta
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger
:
Mentors:
Depends on: 702583 705186 705187 705188 705320 705333 705344 705355 705357 705444
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-25 09:48 PST by :Ms2ger
Modified: 2011-12-18 07:18 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove nsAXPCNativeCallContext::{GetRetValPtr,GetReturnValueWasSet,SetReturnValueWasSet}; s (3.74 KB, patch)
2011-12-06 13:56 PST, :Ms2ger
no flags Details | Diff | Review
Patch v2 (7.37 KB, patch)
2011-12-06 14:55 PST, :Ms2ger
bobbyholley: review+
Details | Diff | Review

Description :Ms2ger 2011-11-25 09:48:42 PST
We can now return jsvals through IDL rather than using these APIs.
Comment 1 :Ms2ger 2011-11-25 09:50:42 PST
(As requested in bug 705186 comment 1.)
Comment 2 :Ms2ger 2011-12-06 13:56:04 PST
Created attachment 579449 [details] [diff] [review]
Remove nsAXPCNativeCallContext::{GetRetValPtr,GetReturnValueWasSet,SetReturnValueWasSet}; s
Comment 3 Bobby Holley (PTO through June 13) 2011-12-06 14:23:36 PST
We also need to remove support for this in XPCWrappedNative.cpp, no?
Comment 4 :Ms2ger 2011-12-06 14:55:07 PST
Created attachment 579468 [details] [diff] [review]
Patch v2

Well... Yes.
Comment 6 Bobby Holley (PTO through June 13) 2011-12-06 17:22:44 PST
Comment on attachment 579468 [details] [diff] [review]
Patch v2

r=bholley. Also, sr=bz from IRC.

Thanks for doing this. :-)
Comment 7 :Ms2ger 2011-12-18 07:18:36 PST
https://hg.mozilla.org/mozilla-central/rev/dddd8c46f9a9

MDC doesn't know about nsAXPCNativeCallContext, and I claim that's a good thing, so no dev-doc-needed.

Note You need to log in before you can comment on or make changes to this bug.