705305 - Apps: Validation is showing some pass results but the app was not even found (404 error)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Ioan C.]

1. Login via BrowserID to https://apps-preview-dev.allizom.org/
2. Submit an app - make sure you enter https://marblerun.at/manifest.webapp (that is HTTPS instead of Http)
3. Validate.
4. Check the validation report page. You should get 404 Not Found. (mine is https://apps-preview-dev.allizom.org/en-US/developers/upload/50823976c7aa44f4a687aad8728137f2)

Actual results: Error 404 (Not Found) is returned for General Tests. All other test types are saying "Success. All tests have passed". This is wrong because they were not run at all.

Expected results: The other test types should say "Not Executed" (in Gray color).

Comment 1

[Ioan C.]

Attachment: validation_results

Comment 2

[Kumar McMillan [:kumar]]

Matt, in these validation results the key 'ending_tier' is missing from the JSON dict. That key used to always be there. Can you look into it? The UI uses ending_tier to know which tests didn't run.

Here is the JSON output from the above manifest, from https://marblerun.at/manifest.webapp



{
    "url": "/en-US/developers/standalone-upload/50823976c7aa44f4a687aad8728137f2",
    "full_report_url": "/en-US/developers/upload/50823976c7aa44f4a687aad8728137f2",
    "validation": {
        "errors": 1,
        "messages": [{
            "tier": 1,
            "message": "<a href=\"https://outgoing.stage.mozilla.com/v1/e57a632df8afc11b40e612de1f91840633e16a3c/https%3A//marblerun.at/manifest.webapp\" rel=\"nofollow\">https://marblerun.at/manifest.webapp</a> responded with 404 (Not Found).",
            "type": "error"
        }],
        "success": false
    },
    "upload": "50823976c7aa44f4a687aad8728137f2",
    "error": null
}

Comment 3

[Matt Basta [:basta]]

The validator doesn't pull add-ons down from URLs. It looks like that JSON is possibly generated by zamboni.

Comment 4

[Kumar McMillan [:kumar]]

Aha, whoops, right you are. I forgot this code is a JSON wrapper around Django form errors so the bug needs to be fixed there.

Comment 5

[Kumar McMillan [:kumar]]

Fixed https://github.com/mozilla/zamboni/commit/0632d381d3224b9dbcc2caa99be99e8e8b16f9dc

Comment 6

[krupa raj[:krupa]]

Cristian, do you mind verifying this bug? Thanks!

Comment 7

[Victor Carciu]

Verified as fixed.

Comment 8

[Victor Carciu]

Attachment: Postfix Screenshot.

Comment 9

[Victor Carciu]

Attachment: Postfix Screenshot