70540 - Import "Mail", Create new message and Account Wizard doesn't appear

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Ninoschka Baca]

Build 2001-02-28-09: NT4

Overview: File|Import|Mail. Create a new message and an error appears. Instead
the Account Wizard should appear.

Steps to reproduce:
1. Select File|Import|Mail. This only imports the messages and not the settings,
as expected. 
2. An account should appear which is just like Local Folders (for some reason it
is not called Local Folders). 
3. Create a new message and send it. 

Actual Results: An error appears "An error occured while creating a message
compose window. Please try again. Type Error: item has no properties". 

Expected Results: Since an account actually doesn't exist, when the user goes to
create a new message the Account Wizard should appear. This is the behavior that
occurs in a new profile if the user cancels out of the Account Wizard and tries
to create a new message.

Additional Information:
- The above occurs when Importing Mail from Outlook Express or Outlook
- Tried Eudora but it's crashing (bug# 57125)

Comment 1

[Ninoschka Baca]

Marking nsbeta1 because an error should not occur. Rather the Account Wizard
should appear.

Comment 2

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 3

[scottputterman]

moving to mozilla0.9.1

Comment 4

[(not reading, please use [e-mail] instead)]

giving all my import bugs to chuang

Comment 5

[scottputterman]

moving to 0.9.2

Comment 6

[chuang]

After the 3 steps, the accountCount in verifyAccounts() is greater than zero 
When compose window calling verifyAccounts() and invalidAccounts.length is zero.  
The openWizard is never set to true.  So the Account Wizard doesn't appear.

Question for Seth:
How do we know there's no identity in the account even if the accountCount is 
greater than zero?  Can I check this in verifyAccounts()?

Comment 7

[chuang]

The right way to fix this problem is to set the imported Mail account as an
invalid account so the account manager can come up.

Comment 8

[scottputterman]

moving to 0.9.3

Comment 9

[esther]

no longer nsbeta1+, because new bug written to 86991 is nsbeta1+  and is an
easier fix that will alleviate the confusion.  

Comment 10

[scottputterman]

moving to 0.9.4

Comment 11

[scottputterman]

moving to 0.9.5

Comment 12

[scottputterman]

reassigning to racham

Comment 13

[scottputterman]

moving to 1.0

Comment 14

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 15

[varada]

Taking bugs from bhuvan.

Comment 16

[varada]

*** Bug 131384 has been marked as a duplicate of this bug. ***

Comment 17

[varada]

Attachment: Patch V1

When checking for invalid accounts we now check to see if when it is a single
account it has an identity if not it is a local folder. Iff its a local folder
then invoke the account wizard during compose only.

Comment 18

[racham]

Comment on attachment 82708 [details] [diff] [review]
Patch V1

r=bhuvan.

Please add comments above the following statement for future reference.

+	 if (openWizard || prefillAccount || (zeroIdCount && wizardcallback))

We are doing openWizard if  MessengerMigration returns some kind of error
(including those cases where there is nothing to migrate). Condition
prefillAccount is valid, if there is an invalid account already and so on.

Comment 19

[(not reading, please use [e-mail] instead)]

sr=sspitzer, once you add a comment (like bhuvan suggests)

Comment 20

[varada]

Added the necessary comments and checked into trunk.

Comment 21

[varada]

Marking Fixed in trunk.

Comment 22

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers' approval.  After, checking in, please add the fixed1.0 keyword.

Comment 23

[Ninoschka Baca]

Reopening.

Trunk build 2002-05-20-08: WinMe
The problem still occurs in the trunk build. 

Comment 24

[varada]

Attachment: Patch Ver 2.0

Previously I had simulated the condition of ending up with a local folder by
deleting an existing single account but there is a second account being created
for the local server when we finish importing OE and launching the compose
window. I am therefore changing the if condition slightly to check for
validIdentities rather than zeroIdCount.

Comment 25

[scottputterman]

removing adt1.0.0+.  When this gets checked into the trunk, nbaca can you verify
this first before we make the decision to check this into the branch?

Comment 26

[racham]

Comment on attachment 84554 [details] [diff] [review]
Patch Ver 2.0

r=bhuvan

Comment 27

[(not reading, please use [e-mail] instead)]

1)

with your new patch, we're ending up with this backwards code:


            if (!identity.valid) {
                invalidAccounts[invalidAccounts.length] = account;
                continue;
            }
+            else
+              anyValidIdentity = true;

Instead, cleanup the code and do:

            if (identity.valid)
              anyValidIdentity = true;
            else
              invalidAccounts[invalidAccounts.length] = account;
           
            
2)

+        //anyValidIdentity is true when there are identities for any account
+        //and remains false if there is only a local folder.

this comment isn't 100% correct.  

anyValidIdentity is true when you've got at least one *valid* identity,
Since local folders is an identity-less account, if you only have
local folders, it will be false.

3)

please describe which different scenarios you tested.

Comment 28

[Ninoschka Baca]

Just let me know when and I can check it before it goes into the branch.

Comment 29

[varada]

Attachment: Patch V 2.0 with style changes.

Changed the style.

Comment 30

[Ninoschka Baca]

Using Varada's special builds for trunk and branch it appears to be working.
Here are some scenarios I tried:

1. New profile, open Mail, exit the Account Wizard, Import Outlook Express,
select Compose button and Account Wizard appears. It successfully created an
IMAP account in one case and a POP account in another.

2. Tried the same scenario but used the File|New|Message menu to open a Compose
window.

Unfortunately I could not check Downstream Activation since it doesn't appear to
work on Varada's system. I was able to add an existing WebMail account.

Comment 31

[(not reading, please use [e-mail] instead)]

Comment on attachment 84835 [details] [diff] [review]
Patch V 2.0 with style changes.

sr=sspitzer

one last suggestion, 

before checking in, change

anyValidIdentity to gAnyValidIdentity

since it is a global.

Comment 32

[varada]

Marking fixed on Trunk.

Comment 33

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Driver's approval.  After, checking in, please add the fixed1.0 keyword.

Comment 34

[Ninoschka Baca]

Trunk build 2002-05-24: WinMe, Linux RH 7.1, Mac 10.1.3
Reopening, sorry but it's not working or the fix didn't make it into the trunk.
Here is what happens:

- New profile
- When Mail opens cancel out of Account Wizard
- Import Mail (i.e. from Eudora)
- Select the Compose button and a compose window appears, then the Account
Wizard appears as expected
- The Email Account radio button is selected by default, select the Next button

Actual Results: The Account Wizard is gone and returns focus back to the blank
compose window.

Expected Results: The Account Wizard's Identity dialog should appear asking for
Your Name and Email Address.

Comment 35

[varada]

Closing this bug as marked fixed. This bug is about the appearance of the
account wizard when we do not have any identities for any account viz only the
Local Folders or not even that. The bug that you are referring to is
15874(bugscape bug). This does not happen in mozilla. The reason you didnt see
this during the testing was that my build had both my fixes in them. I checked
in the fix to the other bug into both the commercial trunk and branch today. You
will see them in the next daily build.

Comment 36

[Ninoschka Baca]

Verified Fixed, thanks for the clarification :)

Comment 37

[scottputterman]

Adding adt1.0.1+ for adt approval for branch checkin for the 1.0.1 milestone. 
Please get drivers approval before checking in.

Comment 38

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP, and replace the mozilla1.0.1+ keyword
with fixed1.0.1 once it's landed there.

Comment 39

[varada]

Checked into the MOZILLA_1_0_0_BRANCH.

Comment 40

[Ninoschka Baca]

Branch build 2002-06-11: WinMe
Verified1.0.1.

Comment 41

[varada]

*** Bug 66638 has been marked as a duplicate of this bug. ***