Use MOZ_CHECK_HEADERS to check for cpuid.h

RESOLVED FIXED in mozilla11

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 577091 [details] [diff] [review]
Use MOZ_CHECK_HEADERS to check for cpuid.h

We currently use __GNUC__ and __GNUC_MINOR__, which fails for clang.

While this bug depends on 705461 for check-in, it should be trivial to review in parallel, so *please* don't wait for that one to be closed first :-)
Attachment #577091 - Flags: review?(ted.mielczarek)
Now that 705461 landed, a try is at

https://tbpl.mozilla.org/?tree=Try&rev=1613612988ac
Comment on attachment 577091 [details] [diff] [review]
Use MOZ_CHECK_HEADERS to check for cpuid.h

Review of attachment 577091 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/mozcommonheader.m4
@@ +42,5 @@
> +	MOZ_CHECK_HEADERS(gnu/libc-version.h nl_types.h)
> +	MOZ_CHECK_HEADERS(malloc.h)
> +	MOZ_CHECK_HEADERS(X11/XKBlib.h)
> +	MOZ_CHECK_HEADERS(io.h)
> +	MOZ_CHECK_HEADERS(cpuid.h)

Can you either move these all into one MOZ_CHECK_HEADERS invocation, or move it to one-header-per-invocation? The mix here is weird (and probably historical).
Attachment #577091 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → respindola
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7c4eadbd0b78
https://hg.mozilla.org/mozilla-central/rev/7c4eadbd0b78
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.