Closed Bug 705850 Opened 11 years ago Closed 11 years ago

Change about:config placeholder text from "Filter Preferences" to "Search Preferences"

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

minimal patch
1.70 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Bug 502492 changed the label of toolkit's about:config from "Filter" to "Search".
I'd suggest to do the same for the placeholder text.
Where can you see the placeholder? Is it Fennec only feature? I do not see it. Can you attach a screenshot?
Attached image screenshot (obsolete) — 
Yep, Fennec reimplemented it as an xhtml page.
I am not sure where the fennec source files are located. Can you find the relevant file on http://hg.mozilla.org/ ? It seems not to be in http://hg.mozilla.org/mobile-browser/file/8167d57cab8e/locales/en-US/chrome/config.dtd , that whole dir is from 2011-04-01 (outdated) and also the strings in that file do not match your screenshot. There is probably another repository somewhere. Maybe it has something to do with the new native GUI?
It lives on the birch project branch right now:
http://mxr.mozilla.org/projects-central/source/birch/
http://hg.mozilla.org/projects/birch/pushloghtml

But don't worry, I already wrote the patch before filing the bug ;-)
Attached patch minimal patch — — Splinter Review 
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED

        Attachment #577355 -
        Flags: review?(mark.finkle)

    
  

        Attachment #577348 -
        Attachment is obsolete: true

        Attachment #577355 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
http://hg.mozilla.org/projects/birch/rev/0494de42f547
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Samsung Nexus S (Android 4.0.1)
20111130040240
http://hg.mozilla.org/projects/birch/rev/4e745f151abd
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.