502492 - Change about:config text box label to Search:

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090705 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090705 Minefield/3.6a1pre

All other search text boxes (bookmarks sidebar search, history sidebar search, cookies search, remembered passwords search) use the label Search:

Since filtering is the same as searching, I think it would be nice to follow the convention.

Reproducible: Always

Steps to Reproduce:
1. Go to about:config
Actual Results:  
See Filter: label

Expected Results:  
It should be a Search: label

Comment 1

[Simon Bünzli]

Hi Andrés. Thanks for continuing to look into these minor polish issues! Have you ever considered creating patches for these (wording changes are quite simple to do, once you've got your head around Mercurial - on Windows, this is even quite easy with TortoiseHg)? That will significantly speed up the process and should get you many of these bugs actually fixed for Firefox.next.

Also, please create a meta-bug for your issues, make all of them block the meta-bug and CC [e-mail] on it, so that he can agree/disagree where he sees fit (and buy you some beer, once you've added enough polish ;-)).

Comment 2

[Maxwell J. Koo]

Attachment: Proposed patch

Went ahead and implemented this change, seems the new wording is more consistent with the behavior described in bug 449178, to which my friend says he'll be submitting a patch soon. This patch also refactors some of the filterXXX functions in the about:config config.js file to match the new wording.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 491635 [details] [diff] [review]
Proposed patch

ui-r+, but I think we're past string freeze for Firefox 4

Comment 4

[:aceman]

Who can give superreview for FF7?

Comment 5

[Kai Liu]

You don't need a superreview for a trivial change like this.  But it would help to explicitly request someone to do the review instead of asking the wind...
http://www.mozilla.org/projects/toolkit/review.html

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 491635 [details] [diff] [review]
Proposed patch

The majority of this patch seems to be unnecessary for just changing the label

Comment 7

[Wayne Mery (:wsmwk)]

> The majority of this patch seems to be unnecessary for just changing the label

Indeed. Staying with "Filter" and having looked at both FF and TB, the only choices appear L and R. I does not work in Tbird - it focuses the View widget. 

Maxwell, if no one objects to going with R would you code up a new patch?

Comment 8

[:aceman]

I could make the patch but need to hear the consensus.
There even is a ui-review+ about changing it to Search.
Wayne, why do you suggest to stay with "Filter"? I think Dave just objects to changing all the related function names.
So I'll just keep the changes in toolkit/components/viewconfig/content/config.xul and toolkit/components/viewconfig/content/config.xul as AFAIK the identifier needs to be changed when the string changes (due to translations).

Comment 9

[:aceman]

Attachment: reduced patch

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 575945 [details] [diff] [review]
reduced patch

Review of attachment 575945 [details] [diff] [review]:
-----------------------------------------------------------------

Fine code-wise, needs UX sign-off before landing though.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

FWIW, it had ux-signoff before, pretty sure that can carry over!

Comment 12

[:aceman]

The original patch had 'S' as accesskey so please review again.
I chose 'r' for access key, because 's' is already taken by 'Hi_s_tory' in main menu. Interestingly, there is another _S_earch in Ctrl+H sidebar using S as accesskey. A bug or not a problem, as the classic menu is no longer the default?

Comment 13

[:aceman]

Hm, no answer but a ui+ from Alex Limi.
So it is probably OK. Requesting checkin.

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f9cfa8e36f56

Comment 15

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f9cfa8e36f56