705932 - Inspector should allow copying the current element's id/classes

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Pedro Alves]

Use case: I'm finding the elements I want to style with the inspector. I want to copy the selected element's id and class to my CSS code. The inspector doesn't allow me to do that and I need to manually type them


Would be great to have the ability either to select the text or copy it to the clipboard somehow

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 577515 [details] [diff] [review]
patch v1

Review of attachment 577515 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/highlighter.css
@@ +69,5 @@
> +
> +#highlighter-nodeinfobar-id,
> +.highlighter-nodeinfobar-class,
> +#highlighter-nodeinfobar-tagname {
> +  -moz-user-select: text;

My understanding is that this is the default. I can't see anywhere else in highlighter.css where moz-user-select would be set to something else, but I'll assume this is needed?

Comment 3

[Paul Rouget [:paul]]

(In reply to Joe Walker from comment #2)
> Comment on attachment 577515 [details] [diff] [review] [diff] [details] [review]
> patch v1
> 
> Review of attachment 577515 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/highlighter.css
> @@ +69,5 @@
> > +
> > +#highlighter-nodeinfobar-id,
> > +.highlighter-nodeinfobar-class,
> > +#highlighter-nodeinfobar-tagname {
> > +  -moz-user-select: text;
> 
> My understanding is that this is the default.

Not in XUL: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#15

Comment 4

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] from comment #3)
> (In reply to Joe Walker from comment #2)
> > > +  -moz-user-select: text;
> > 
> > My understanding is that this is the default.
> 
> Not in XUL:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#15

Duh - I didn't think that this might be XUL. Thanks.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 577515 [details] [diff] [review]
patch v1

>+#highlighter-nodeinfobar-container[locked] #highlighter-nodeinfobar {

#highlighter-nodeinfobar-container[locked] > #highlighter-nodeinfobar {

Comment 6

[Dão Gottwald [:dao]]

Comment 5 needs to be addressed.

Comment 7

[Paul Rouget [:paul]]

Sorry, I missed it.

Comment 8

[Paul Rouget [:paul]]

Attachment: patch v1.1

Addressed Dao's comment.

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/1e3f58d1bde7

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/1e3f58d1bde7

Comment 11

[Pedro Alves]

Dunno if it's a regression or I just never tested it, but I can select the test (in OSX) but not copy to clipboard

Comment 12

[Pedro Alves]

Working in tonight's build, thanks!

Comment 13

[Paul Rouget [:paul]]

This happens again (can't copy).

Comment 14

[Paul Rouget [:paul]]

Any idea of what going on here? See bug 722398?