Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove additional Java Consoles




6 years ago
6 years ago


(Reporter: fligtar, Assigned: rstrong)


Firefox 9
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox9 fixed, firefox10 fixed, firefox11 fixed)


(Whiteboard: [qa?])


(1 attachment)



6 years ago
In bug 654131, we removed a number of Java Consoles in use at the time, but several more have been added since then accounting for tens of millions of users. We should update the list again.


I'd like this to land on Beta or at least Aurora -- it's very low risk and will help clean up this mess without waiting months.
Created attachment 577775 [details] [diff] [review]
patch rev1
Assignee: nobody → robert.bugzilla
Attachment #577775 - Flags: review?(netzen)
Comment on attachment 577775 [details] [diff] [review]
patch rev1

Looks good, verified it matches up to each of the IDs in the original post a and the NSIS logic lib code looks good in PostUpdate.
Attachment #577775 - Flags: review?(netzen) → review+
Pushed to fx-team
Whiteboard: [fixed-in-fx-team]
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
fligtar, if you still want this on other branches please nominate and include the justification for product drivers. Thanks!

Comment 6

6 years ago
Comment on attachment 577775 [details] [diff] [review]
patch rev1

This patch removes additional Java Consoles that have surfaced since our original removal of Java Consoles a few months ago in Firefox 8. These versions account for tens of millions of users and can cause users to see incompatibility dialogs when upgrading. This is a low risk patch that just adds additional GUIDs to the list of removals on upgrade. Would like it to land sooner than Firefox 11.
Attachment #577775 - Flags: approval-mozilla-beta?
Attachment #577775 - Flags: approval-mozilla-aurora?
Specifically, the add-on compatibility dialog after upgrading since we don't report incompatible extensions located in the installation directory's extensions directory.

Comment 8

6 years ago
Comment on attachment 577775 [details] [diff] [review]
patch rev1

[Triage Comment]
We're using a known mechanism to remove Java Consoles, so unless the GUIDs are incorrect for some reason, this is very low risk. Approving for aurora and beta. Please land asap.
Attachment #577775 - Flags: approval-mozilla-beta?
Attachment #577775 - Flags: approval-mozilla-beta+
Attachment #577775 - Flags: approval-mozilla-aurora?
Attachment #577775 - Flags: approval-mozilla-aurora+

Comment 9

6 years ago
Please land ASAP to make it into today's beta.
Pushed to mozilla-aurora

Pushed to mozilla-beta
status-firefox10: --- → fixed
status-firefox11: --- → fixed
status-firefox9: --- → fixed
Target Milestone: Firefox 11 → Firefox 9
Flags: in-testsuite-
Do we know what versions of Java SE installs these consoles so QA can verify the fix?
Whiteboard: [qa?]

Comment 12

6 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #11)
> Do we know what versions of Java SE installs these consoles so QA can verify
> the fix?

I don't know the specific Java version numbers tied with installation; it's probably a good bet that these come with the most recent ones, as they'll usually get a couple users for a few weeks and then surge to become the most-used version all of the sudden.
You need to log in before you can comment on or make changes to this bug.