705997 - Remove additional Java Consoles

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Justin Scott [:fligtar]]

In bug 654131, we removed a number of Java Consoles in use at the time, but several more have been added since then accounting for tens of millions of users. We should update the list again.

{CAFEEFAC-0016-0000-0027-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0028-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0029-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0030-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0031-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0032-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0001-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0002-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0003-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0004-ABCDEFFEDCBA}

I'd like this to land on Beta or at least Aurora -- it's very low risk and will help clean up this mess without waiting months.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 577775 [details] [diff] [review]
patch rev1

Looks good, verified it matches up to each of the IDs in the original post a and the NSIS logic lib code looks good in PostUpdate.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/984277762e0e

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/984277762e0e

Comment 5

[Robert Strong (they/them - no direct email)]

fligtar, if you still want this on other branches please nominate and include the justification for product drivers. Thanks!

Comment 6

[Justin Scott [:fligtar]]

Comment on attachment 577775 [details] [diff] [review]
patch rev1

This patch removes additional Java Consoles that have surfaced since our original removal of Java Consoles a few months ago in Firefox 8. These versions account for tens of millions of users and can cause users to see incompatibility dialogs when upgrading. This is a low risk patch that just adds additional GUIDs to the list of removals on upgrade. Would like it to land sooner than Firefox 11.

Comment 7

[Robert Strong (they/them - no direct email)]

Specifically, the add-on compatibility dialog after upgrading since we don't report incompatible extensions located in the installation directory's extensions directory.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 577775 [details] [diff] [review]
patch rev1

[Triage Comment]
We're using a known mechanism to remove Java Consoles, so unless the GUIDs are incorrect for some reason, this is very low risk. Approving for aurora and beta. Please land asap.

Comment 9

[Alex Keybl [:akeybl]]

Please land ASAP to make it into today's beta.

Comment 10

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/f294d7315211

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/75ab3bc0ea30

Comment 11

[u279076]

Do we know what versions of Java SE installs these consoles so QA can verify the fix?

Comment 12

[Justin Scott [:fligtar]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #11)
> Do we know what versions of Java SE installs these consoles so QA can verify
> the fix?

I don't know the specific Java version numbers tied with installation; it's probably a good bet that these come with the most recent ones, as they'll usually get a couple users for a few weeks and then surge to become the most-used version all of the sudden.