The default bug view has changed. See this FAQ.

Remove additional Java Consoles

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fligtar, Assigned: rstrong)

Tracking

Trunk
Firefox 9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox9 fixed, firefox10 fixed, firefox11 fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
In bug 654131, we removed a number of Java Consoles in use at the time, but several more have been added since then accounting for tens of millions of users. We should update the list again.

{CAFEEFAC-0016-0000-0027-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0028-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0029-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0030-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0031-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0032-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0001-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0002-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0003-ABCDEFFEDCBA}
{CAFEEFAC-0017-0000-0004-ABCDEFFEDCBA}

I'd like this to land on Beta or at least Aurora -- it's very low risk and will help clean up this mess without waiting months.
Created attachment 577775 [details] [diff] [review]
patch rev1
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #577775 - Flags: review?(netzen)
Comment on attachment 577775 [details] [diff] [review]
patch rev1

Looks good, verified it matches up to each of the IDs in the original post a and the NSIS logic lib code looks good in PostUpdate.
Attachment #577775 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/984277762e0e
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/984277762e0e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
fligtar, if you still want this on other branches please nominate and include the justification for product drivers. Thanks!
(Reporter)

Comment 6

5 years ago
Comment on attachment 577775 [details] [diff] [review]
patch rev1

This patch removes additional Java Consoles that have surfaced since our original removal of Java Consoles a few months ago in Firefox 8. These versions account for tens of millions of users and can cause users to see incompatibility dialogs when upgrading. This is a low risk patch that just adds additional GUIDs to the list of removals on upgrade. Would like it to land sooner than Firefox 11.
Attachment #577775 - Flags: approval-mozilla-beta?
Attachment #577775 - Flags: approval-mozilla-aurora?
Specifically, the add-on compatibility dialog after upgrading since we don't report incompatible extensions located in the installation directory's extensions directory.

Comment 8

5 years ago
Comment on attachment 577775 [details] [diff] [review]
patch rev1

[Triage Comment]
We're using a known mechanism to remove Java Consoles, so unless the GUIDs are incorrect for some reason, this is very low risk. Approving for aurora and beta. Please land asap.
Attachment #577775 - Flags: approval-mozilla-beta?
Attachment #577775 - Flags: approval-mozilla-beta+
Attachment #577775 - Flags: approval-mozilla-aurora?
Attachment #577775 - Flags: approval-mozilla-aurora+

Comment 9

5 years ago
Please land ASAP to make it into today's beta.
Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/f294d7315211

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/75ab3bc0ea30
status-firefox10: --- → fixed
status-firefox11: --- → fixed
status-firefox9: --- → fixed
Target Milestone: Firefox 11 → Firefox 9
Flags: in-testsuite-
Do we know what versions of Java SE installs these consoles so QA can verify the fix?
Whiteboard: [qa?]
(Reporter)

Comment 12

5 years ago
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #11)
> Do we know what versions of Java SE installs these consoles so QA can verify
> the fix?

I don't know the specific Java version numbers tied with installation; it's probably a good bet that these come with the most recent ones, as they'll usually get a couple users for a few weeks and then surge to become the most-used version all of the sudden.
You need to log in before you can comment on or make changes to this bug.