Closed Bug 706113 Opened 12 years ago Closed 12 years ago

Remove null checks after constructors in VideoDocument.cpp

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: jaws, Assigned: Tobbi)

References

Details

(Whiteboard: [good first bug][mentor=Ms2ger])

Attachments

(1 file)

patch
897 bytes, patch
smaug
: review+
jaws
: feedback+
Details | Diff | Splinter Review 
> mozilla::dom::VideoDocument* doc = new mozilla::dom::VideoDocument();
> NS_ENSURE_TRUE(doc, NS_ERROR_OUT_OF_MEMORY);

These checks are unnecessary since we are not using |new (std::nothrow)|.

http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#161

http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#87
Blocks: deadcode
No longer depends on: deadcode
Whiteboard: [good first bug][mentor=Ms2ger]
Attached patch patch — — Splinter Review 
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED

        Attachment #578019 -
        Flags: review?(jwein)

    
    

    
  
Comment on attachment 578019 [details] [diff] [review]
patch

Looks good to me, but I can't review this. I've forwarded the review to Olli.

        Attachment #578019 -
        Flags: review?(jwein)

        Attachment #578019 -
        Flags: review?(bugs)

        Attachment #578019 -
        Flags: feedback+

        Attachment #578019 -
        Flags: review?(bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/62df7e3891cd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11

          You need to log in
          before you can comment on or make changes to this bug.