> mozilla::dom::VideoDocument* doc = new mozilla::dom::VideoDocument(); > NS_ENSURE_TRUE(doc, NS_ERROR_OUT_OF_MEMORY); These checks are unnecessary since we are not using |new (std::nothrow)|. http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#161 http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#87
Created attachment 578019 [details] [diff] [review] patch
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
Attachment #578019 - Flags: review?(jwein)
Comment on attachment 578019 [details] [diff] [review] patch Looks good to me, but I can't review this. I've forwarded the review to Olli.
Attachment #578019 - Flags: review?(bugs) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.