Last Comment Bug 706113 - Remove null checks after constructors in VideoDocument.cpp
: Remove null checks after constructors in VideoDocument.cpp
[good first bug][mentor=Ms2ger]
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: Tobias (:Tobbi) Markus
: Maire Reavy [:mreavy] Please needinfo me
Depends on:
Blocks: deadcode
  Show dependency treegraph
Reported: 2011-11-29 07:37 PST by Jared Wein [:jaws] (please needinfo? me)
Modified: 2011-12-02 03:17 PST (History)
3 users (show)
bzbarsky: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (897 bytes, patch)
2011-11-30 11:09 PST, Tobias (:Tobbi) Markus
bugs: review+
jaws: feedback+
Details | Diff | Splinter Review

Description User image Jared Wein [:jaws] (please needinfo? me) 2011-11-29 07:37:20 PST
> mozilla::dom::VideoDocument* doc = new mozilla::dom::VideoDocument();

These checks are unnecessary since we are not using |new (std::nothrow)|.
Comment 1 User image Tobias (:Tobbi) Markus 2011-11-30 11:09:46 PST
Created attachment 578019 [details] [diff] [review]
Comment 2 User image Jared Wein [:jaws] (please needinfo? me) 2011-11-30 17:06:48 PST
Comment on attachment 578019 [details] [diff] [review]

Looks good to me, but I can't review this. I've forwarded the review to Olli.
Comment 3 User image Boris Zbarsky [:bz] (still a bit busy) 2011-12-01 11:29:23 PST
Comment 4 User image Marco Bonardo [::mak] 2011-12-02 03:17:29 PST

Note You need to log in before you can comment on or make changes to this bug.