Closed
Bug 706113
Opened 12 years ago
Closed 12 years ago
Remove null checks after constructors in VideoDocument.cpp
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jaws, Assigned: Tobbi)
References
Details
(Whiteboard: [good first bug][mentor=Ms2ger])
Attachments
(1 file)
897 bytes,
patch
|
smaug
:
review+
jaws
:
feedback+
|
Details | Diff | Splinter Review |
> mozilla::dom::VideoDocument* doc = new mozilla::dom::VideoDocument(); > NS_ENSURE_TRUE(doc, NS_ERROR_OUT_OF_MEMORY); These checks are unnecessary since we are not using |new (std::nothrow)|. http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#161 http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#87
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 578019 [details] [diff] [review] patch Looks good to me, but I can't review this. I've forwarded the review to Olli.
Attachment #578019 -
Flags: review?(jwein)
Attachment #578019 -
Flags: review?(bugs)
Attachment #578019 -
Flags: feedback+
Updated•12 years ago
|
Attachment #578019 -
Flags: review?(bugs) → review+
Updated•12 years ago
|
Keywords: checkin-needed
![]() |
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/62df7e3891cd
Flags: in-testsuite-
Keywords: checkin-needed
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62df7e3891cd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•