Closed Bug 706194 Opened 11 years ago Closed 11 years ago

Adapt and check in tests from webkit for new unicode-bidi attributes


(Core :: Layout: Text and Fonts, defect)

Not set





(Reporter: smontagu, Assigned: smontagu)



(Keywords: rtl)


(3 files)

Keywords: rtl
Attached patch Patch part 1Splinter Review
For clarity I'll do this in 2 parts: this is the initial adaptation of the webkit tests to our test harnesses, which has lots of failures.
Attachment #584392 - Flags: review?(roc)
Attached patch Patch part 2Splinter Review
... and these are the changes to make the tests pass (modulo bugs noted in comments)
Attachment #584394 - Flags: review?(roc)
Comment on attachment 584394 [details] [diff] [review]
Patch part 2

Reasons for the changes:

>+    text-align: left;
 in a number of tests, because of a difference between the way that we and webkit handle unicode-bidi: plaintext. If no text-align is specified, we align paragraphs to the left and right depending on the resolved direction of each paragraph, but webkit aligns everything depending on the direction of the enclosing element. See and

>diff --git a/layout/reftests/bidi/unicode-bidi-isolate-basic.js b/layout/reftests/bidi/unicode-bidi-isolate-basic.js

>-    var strongRTLs = ['ש', 'נ', 'ב', 'ג', 'ק', 'כ', 'ע'];
>+    var strongRTLs = ['א', 'ב', 'ג', 'ד', 'ה', 'ו', 'ז'];

Using Hebrew letters in alphabetical order makes the test results easier to read for me (the original used the same key positions as a,b,c,d,e,f,g)

>diff --git a/layout/style/test/test_default_bidi_css.html b/layout/style/test/test_default_bidi_css.html

>-    ['div', {'dir': 'rtl'}, 'rtl', 'embed'],
>+    ['div', {'dir': 'ltr'}, 'ltr', '-moz-isolate'],
>+    ['div', {'dir': 'rtl'}, 'rtl', '-moz-isolate'],
>     ['div', {'dir': 'auto'}, 'ltr', '-moz-isolate'],
>-    ['div', {'dir': ''}, 'ltr', 'embed'],
>+    ['div', {'dir': ''}, 'ltr', '-moz-isolate'],

>-    ['pre', {}, 'ltr', 'normal'],
>-    ['pre', {'dir': 'ltr'}, 'ltr', 'embed'],
>-    ['pre', {'dir': 'rtl'}, 'rtl', 'embed'],
>+    ['pre', {}, 'ltr', '-moz-isolate'],
>+    ['pre', {'dir': 'ltr'}, 'ltr', '-moz-isolate'],
>+    ['pre', {'dir': 'rtl'}, 'rtl', '-moz-isolate'],
>     ['pre', {'dir': 'auto'}, 'ltr', '-moz-plaintext'],
>-    ['pre', {'dir': ''}, 'ltr', 'embed'],
>+    ['pre', {'dir': ''}, 'ltr', '-moz-isolate'],

Another difference between us and webkit: we give block elements with a dir attribute -moz-isolate, not embed ( and
Depends on: 713621
Attached patch Patch part 3Splinter Review
Assuming that we want to WONTFIX bug 713621, this makes the necessary changes to test_default_bidi_css.html
Attachment #603424 - Flags: review?(dbaron)
Comment on attachment 603424 [details] [diff] [review]
Patch part 3

Attachment #603424 - Flags: review?(dbaron) → review+
Sorry, backed out ( for what looked like bustage, but was slightly ahead of myself (and clearly still half asleep!) as was just hg issues. 

Target Milestone: mozilla15 → mozilla14
Followup to fix bad qimport where the non-ASCII text in the tests got mangled :-(

(Having a successful morning here!)
Depends on: 755244
You need to log in before you can comment on or make changes to this bug.