Last Comment Bug 713621 - Inline elements with dir="" should have unicode-bidi: embed
: Inline elements with dir="" should have unicode-bidi: embed
Status: RESOLVED INVALID
: rtl
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks: 706194
  Show dependency treegraph
 
Reported: 2011-12-27 01:50 PST by Simon Montagu :smontagu
Modified: 2012-04-03 00:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.13 KB, patch)
2011-12-27 01:50 PST, Simon Montagu :smontagu
no flags Details | Diff | Splinter Review

Description Simon Montagu :smontagu 2011-12-27 01:50:19 PST
Created attachment 584402 [details] [diff] [review]
Patch

This is revealed by rniwa's tests in bug 706194, specifically test_default_bidi_css.html.
Comment 1 David Baron :dbaron: ⌚️UTC-10 2011-12-27 12:29:23 PST
So for [dir="auto"] we already set unicode-bidi: -moz-isolate.  So is this changing behavior only for invalid values of dir, or am I missing something?  (And is there a spec that says how we should handle invalid values?)
Comment 2 Simon Montagu :smontagu 2011-12-27 14:43:58 PST
(In reply to David Baron [:dbaron] from comment #1)
> So for [dir="auto"] we already set unicode-bidi: -moz-isolate.  So is this
> changing behavior only for invalid values of dir, or am I missing something?

Yes, that's correct.

> (And is there a spec that says how we should handle invalid values?)

http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#bidirectional-text has
 [dir] { unicode-bidi: embed; }
It doesn't seem to be defined other than that.

(By the way, it also has 
 :dir(ltr) { direction: ltr; }
 :dir(rtl) { direction: rtl; }
rather than our
 [dir="ltr"] { direction: ltr; }
 [dir="rtl"] { direction: rtl; }

Is that going to cause any change in behaviour? Will it be worth changing it once we have support for :dir?)
Comment 3 David Baron :dbaron: ⌚️UTC-10 2012-01-24 15:10:19 PST
Since I disagree with the spec here, I posted http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-January/034489.html
Comment 4 Simon Montagu :smontagu 2012-03-06 13:05:20 PST
That got no response, so shall we WONTFIX this and change the tests? I'll attach an extra patch to bug 706194
Comment 5 David Baron :dbaron: ⌚️UTC-10 2012-03-06 13:26:41 PST
Well, it needs a response to get the spec changed... I suppose I should poke Hixie.
Comment 6 David Baron :dbaron: ⌚️UTC-10 2012-04-02 14:28:23 PDT
I think http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-April/035300.html means this is now invalid.
Comment 7 Simon Montagu :smontagu 2012-04-03 00:26:51 PDT
OK, this is invalid (and the review request on attachment 603424 [details] [diff] [review] is renewed ;-) )

Note You need to log in before you can comment on or make changes to this bug.