Inline elements with dir="" should have unicode-bidi: embed

RESOLVED INVALID

Status

()

Core
CSS Parsing and Computation
RESOLVED INVALID
6 years ago
5 years ago

People

(Reporter: smontagu, Unassigned)

Tracking

({rtl})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 584402 [details] [diff] [review]
Patch

This is revealed by rniwa's tests in bug 706194, specifically test_default_bidi_css.html.
Attachment #584402 - Flags: review?(dbaron)
So for [dir="auto"] we already set unicode-bidi: -moz-isolate.  So is this changing behavior only for invalid values of dir, or am I missing something?  (And is there a spec that says how we should handle invalid values?)
(Reporter)

Comment 2

6 years ago
(In reply to David Baron [:dbaron] from comment #1)
> So for [dir="auto"] we already set unicode-bidi: -moz-isolate.  So is this
> changing behavior only for invalid values of dir, or am I missing something?

Yes, that's correct.

> (And is there a spec that says how we should handle invalid values?)

http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#bidirectional-text has
 [dir] { unicode-bidi: embed; }
It doesn't seem to be defined other than that.

(By the way, it also has 
 :dir(ltr) { direction: ltr; }
 :dir(rtl) { direction: rtl; }
rather than our
 [dir="ltr"] { direction: ltr; }
 [dir="rtl"] { direction: rtl; }

Is that going to cause any change in behaviour? Will it be worth changing it once we have support for :dir?)
Since I disagree with the spec here, I posted http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-January/034489.html
(Reporter)

Comment 4

6 years ago
That got no response, so shall we WONTFIX this and change the tests? I'll attach an extra patch to bug 706194
Component: Style System (CSS) → String
QA Contact: style-system → string
Well, it needs a response to get the spec changed... I suppose I should poke Hixie.
Component: String → Style System (CSS)
QA Contact: string → style-system
I think http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-April/035300.html means this is now invalid.
(Reporter)

Comment 7

5 years ago
OK, this is invalid (and the review request on attachment 603424 [details] [diff] [review] is renewed ;-) )
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Component: Style System (CSS) → Serializers
QA Contact: style-system → dom-to-text
Resolution: --- → INVALID
Target Milestone: --- → mozilla13
Version: Trunk → Other Branch
(Reporter)

Updated

5 years ago
Component: Serializers → Style System (CSS)
QA Contact: dom-to-text → style-system
Target Milestone: mozilla13 → ---
Version: Other Branch → Trunk
(Reporter)

Updated

5 years ago
Attachment #584402 - Flags: review?(dbaron)
You need to log in before you can comment on or make changes to this bug.