Last Comment Bug 706430 - Restoring a session without Panorama data fails with Panorama already loaded
: Restoring a session without Panorama data fails with Panorama already loaded
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
-- normal
: Firefox 11
Assigned To: Tim Taubert [:ttaubert]
Depends on:
Blocks: 688695
  Show dependency treegraph
Reported: 2011-11-30 03:40 PST by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1 (5.68 KB, patch)
2011-11-30 04:05 PST, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Splinter Review

Description User image Tim Taubert [:ttaubert] 2011-11-30 03:40:55 PST
Restoring a session that contains no tab groups data over a current session that has Panorama loaded fails and throws errors.


1) Load a clean profile (don't load Panorama).
2) Create two tabs.
3) Save the current session in a variable.
4) Open Panorama and create two groups with one tab per group.
5) Restore the saved session.


Session is not correctly restored and errors are thrown.


We have one group that contains all the tabs from step #2.
Comment 1 User image Tim Taubert [:ttaubert] 2011-11-30 04:05:01 PST
Created attachment 577918 [details] [diff] [review]
patch v1

Added a simple check to see if we got valid tabData for the given tab. If not, there's no need to validate its groupID.

Removed the tabItem._reconnect() call because that is handled by resumeReconnecting() later after GroupItems.reconstitute() has finished.
Comment 2 User image Dietrich Ayala (:dietrich) 2011-11-30 16:16:08 PST
Comment on attachment 577918 [details] [diff] [review]
patch v1

Review of attachment 577918 [details] [diff] [review]:


::: browser/components/tabview/groupitems.js
@@ +2243,5 @@
> +            if (tabData) {
> +              let parentGroup = GroupItems.groupItem(tabData.groupID);
> +
> +              // correct the tab's groupID if necessary

please add more commentary about how and why it needs correction
Comment 3 User image Tim Taubert [:ttaubert] 2011-12-01 01:51:46 PST
Comment 4 User image Tim Taubert [:ttaubert] 2011-12-02 05:53:49 PST

Note You need to log in before you can comment on or make changes to this bug.