706430 - Restoring a session without Panorama data fails with Panorama already loaded

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Restoring a session that contains no tab groups data over a current session that has Panorama loaded fails and throws errors.

STR:

1) Load a clean profile (don't load Panorama).
2) Create two tabs.
3) Save the current session in a variable.
4) Open Panorama and create two groups with one tab per group.
5) Restore the saved session.

Actual:

Session is not correctly restored and errors are thrown.

Expected:

We have one group that contains all the tabs from step #2.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Added a simple check to see if we got valid tabData for the given tab. If not, there's no need to validate its groupID.

Removed the tabItem._reconnect() call because that is handled by resumeReconnecting() later after GroupItems.reconstitute() has finished.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 577918 [details] [diff] [review]
patch v1

Review of attachment 577918 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: browser/components/tabview/groupitems.js
@@ +2243,5 @@
>  
> +            if (tabData) {
> +              let parentGroup = GroupItems.groupItem(tabData.groupID);
> +
> +              // correct the tab's groupID if necessary

please add more commentary about how and why it needs correction

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/020c1f61f9d4

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/020c1f61f9d4