70652 - No Save Image in message context menu.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using mar01 commercial trunk build

No Save Image As in message pane context menu when image selected. There is a
cruft line at the end of the context menu which might be where this is supposed
to be?  Displays as (A ), but doesn't do anything.

Comment 1

[Daniel Brooks [:db48x]]

Steps to reproduce:
1: Send yourself a message with an image in it
2: Get yer Messages
3: view message in preview pane/message window
4: right click on image, note lack of Save Image as...

Comment 2

[Daniel Brooks [:db48x]]

Actually, you should also notice that theres a blank item on the menu, and that
choosing it deletes the message (doh!). Opening the context menu in the message
gives these two errors on the console:

JavaScript error:
chrome://communicator/content/nsContextMenu.js line 120: srGetStrBundle is not d
efined

JavaScript error:
 line 0: contextMenu has no properties

Comment 3

[scottputterman]

resetting milestone and priority.  nominating nsbeta1, mostly for the js error.

Comment 4

[jglick]

Menu spec has:

View Image <name> 
-------------
Copy Image --- Ctrl+C
Copy Image Location 
---------------
Save Image As... 
---------------
Image Properties

http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html#Context

Comment 5

[scottputterman]

marking nsbeta1+

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Mark broke these, and said he'll fix this soon.  Reassigning.

Comment 7

[Mark Olson]

Attachment: patch - keeps things working until bug 56680 is fully fixed

Comment 8

[Peter "jag" Annema]

r=jag

Comment 9

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 10

[Mark Olson]

Fix checked in, thanks for the quick reviews guys.

Comment 11

[Ninoschka Baca]

Build 2001-03-19-12: NT4
Build 2001-03-19-11: Linux RH 6.2
Build 2001-03-19-10: Mac 9.04
Reopening

The Save Image entry is there but it states "Save Image
(INBOX%3E53024?part=1.2&hackID=1)..."

Comment 12

[Mark Olson]

While the problem manifests itself in the same menu item, it is a different/new
bug.  Bug 70655 and this should both remain fixed, and a new bug should be
opened for the fact that the mailnews code cannot get the original image filename.

Comment 13

[Ninoschka Baca]

Verified Fixed.

Note: The problem with the menu item name is logged in bug# 63225.

Comment 14

[Rose Smyth]

Looks like this issue or something v. similar is re-occuring in US build 
2001-07-24-18-0.9.2. Right click on mail sidebar panel, to produce context menu. 
The 'Save Image' label does not appear, only an extraneous hotkey (A).
This is related to German bugscape no. 6837.

Comment 15

[Rose Smyth]

Attachment: See attached screenhot