Last Comment Bug 706644 - Going back from about:home still displays about:home
: Going back from about:home still displays about:home
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: ARM Android
P2 normal (vote)
: ---
Assigned To: Mark Finkle (:mfinkle) (use needinfo?)
: Sebastian Kaspari (:sebastian)
: 707163 (view as bug list)
Depends on:
Blocks: 701380
  Show dependency treegraph
Reported: 2011-11-30 13:35 PST by Steffen Wilberg
Modified: 2016-07-29 14:20 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (5.37 KB, patch)
2011-12-01 21:40 PST, Mark Finkle (:mfinkle) (use needinfo?)
blassey.bugs: review+
Details | Diff | Splinter Review

Description User image Steffen Wilberg 2011-11-30 13:35:39 PST
Going back from about:home updates the location bar and session history, but doesn't display the content of the page loaded before about:home.

1. Open in a new tab.
2. Click the url bar, open about:home.
3. Press the back key.
Expected result: back to
Actual result: is displayed in the url bar, but about:home in the content.

4. Click the url bar, open
5. Press the back key.
Result: You're back on from step 1.
So after step 3, we were indeed back on, as the url bar suggested, and it just didn't display the content of it.
Comment 1 User image Mark Finkle (:mfinkle) (use needinfo?) 2011-12-01 21:40:15 PST
Created attachment 578492 [details] [diff] [review]

The problem here was that hideAboutHome was not being called when going back from about:home to the previous page in the session history.

So I changed the code to use onLocationChange (handleLocationChange) as the place to show and hide the native about:home page. locationChange is always fired, even when loading from session history. So we check to see if we are loading into the active tab and we show if about:home and hide otherwise. Doing the show here also allows us to completely remove the "AboutHome:Show" message and code from aboutHome.xhtml

I tested this patch:
* load about:home, load, load about:home (it showed and hid correctly)
* After loading the above, I went back, back and forward, forward (it showed and hid correctly)
* With an about:home open in a tab, I then added a new tab with (it hid correctly)
* I then switched back to the about:home tab (it showed correctly)
Comment 2 User image Mark Finkle (:mfinkle) (use needinfo?) 2011-12-02 08:22:08 PST
Comment 3 User image Mark Finkle (:mfinkle) (use needinfo?) 2011-12-02 08:27:04 PST
*** Bug 707163 has been marked as a duplicate of this bug. ***
Comment 4 User image Carla Nadastean 2011-12-05 06:28:04 PST
Retested bug with:
Mozilla/5.0 (Android; Linux arm7l; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z (Android 2.3)

Back from "about:home" is working properly.

Verifying bug.

Note You need to log in before you can comment on or make changes to this bug.