Closed Bug 706644 Opened 9 years ago Closed 9 years ago

Going back from about:home still displays about:home


(Firefox for Android Graveyard :: General, defect, P2)



(firefox11 fixed, fennec11+)

Tracking Status
firefox11 --- fixed
fennec 11+ ---


(Reporter: steffen.wilberg, Assigned: mfinkle)




(1 file)

Going back from about:home updates the location bar and session history, but doesn't display the content of the page loaded before about:home.

1. Open in a new tab.
2. Click the url bar, open about:home.
3. Press the back key.
Expected result: back to
Actual result: is displayed in the url bar, but about:home in the content.

4. Click the url bar, open
5. Press the back key.
Result: You're back on from step 1.
So after step 3, we were indeed back on, as the url bar suggested, and it just didn't display the content of it.
Assignee: nobody →
Assignee: → mark.finkle
Priority: -- → P2
Attached patch patchSplinter Review
The problem here was that hideAboutHome was not being called when going back from about:home to the previous page in the session history.

So I changed the code to use onLocationChange (handleLocationChange) as the place to show and hide the native about:home page. locationChange is always fired, even when loading from session history. So we check to see if we are loading into the active tab and we show if about:home and hide otherwise. Doing the show here also allows us to completely remove the "AboutHome:Show" message and code from aboutHome.xhtml

I tested this patch:
* load about:home, load, load about:home (it showed and hid correctly)
* After loading the above, I went back, back and forward, forward (it showed and hid correctly)
* With an about:home open in a tab, I then added a new tab with (it hid correctly)
* I then switched back to the about:home tab (it showed correctly)
Attachment #578492 - Flags: review?(blassey.bugs)
Attachment #578492 - Flags: review?(blassey.bugs) → review+
Closed: 9 years ago
Resolution: --- → FIXED
Duplicate of this bug: 707163
Retested bug with:
Mozilla/5.0 (Android; Linux arm7l; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z (Android 2.3)

Back from "about:home" is working properly.

Verifying bug.
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.