unclosed tab recreated in wrong tab group

RESOLVED FIXED in Firefox 11

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Stefan, Assigned: raymondlee)

Tracking

({regression})

Trunk
Firefox 11
regression

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User Agent:  

Steps to reproduce:

1. Create an App-Tab.
2. Open http://www.spiegel.de
3. Create a second tab group in panorama.
4. Open http://www.stern.de in new tab group.
5. Close (ctrl-w).
6. Undo close (shift ctrl T).


Actual results:

6. App-Tab, spiegel and stern are in the same tab group, second tab group is orphaned.


Expected results:

6. Closed tab is recreated in its tab group.

Regression Range:
good 11.0a1 (2011-11-29) bc48009a6bbb
 bad 11.0a1 (2011-11-30) cc94a16983b0
(Reporter)

Updated

6 years ago
Summary: unclosed tabs recreated in wrong tab group → unclosed tab recreated in wrong tab group

Comment 1

6 years ago
Regression window(m-c)
Works:
http://hg.mozilla.org/mozilla-central/rev/95bca70369ef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111129 Firefox/11.0a1 ID:20111129135020
Fails:
http://hg.mozilla.org/mozilla-central/rev/cc94a16983b0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111130 Firefox/11.0a1 ID:20111130031011
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95bca70369ef&tochange=cc94a16983b0


Regression window(fx-team)
Works:
http://hg.mozilla.org/integration/fx-team/rev/0a6f4e952a3c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111128 Firefox/11.0a1 ID:20111128063909
Fails:
http://hg.mozilla.org/integration/fx-team/rev/1d63a85fea37
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111128 Firefox/11.0a1 ID:20111128100215
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=0a6f4e952a3c&tochange=1d63a85fea37
Triggered by:
1d63a85fea37	Raymond Lee — Bug 705621 - No tab item is selected after removing last tab in a group outside Panorama r=tim
Blocks: 705621
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Other → All
Hardware: Other → All
(Assignee)

Updated

6 years ago
Component: General → Panorama
QA Contact: general → panorama
(Assignee)

Comment 2

6 years ago
Created attachment 578191 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #578191 - Flags: review?(ttaubert)
Comment on attachment 578191 [details] [diff] [review]
v1

Review of attachment 578191 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks!
Attachment #578191 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 4

6 years ago
Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=f22b4f93f946
(Assignee)

Comment 5

6 years ago
Created attachment 578250 [details] [diff] [review]
Patch for checkin

Passed Try
https://tbpl.mozilla.org/?tree=Try&rev=f22b4f93f946
Attachment #578191 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/3cbff4ec7552
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/3cbff4ec7552
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.