Last Comment Bug 706797 - Make AddonRepository.getAddonsByIDs() not send performance data
: Make AddonRepository.getAddonsByIDs() not send performance data
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 11.0
Assigned To: Mark Banner (:standard8)
Depends on: 682356
  Show dependency treegraph
Reported: 2011-12-01 04:54 PST by Mark Banner (:standard8)
Modified: 2011-12-01 11:48 PST (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

The fix (1.31 KB, patch)
2011-12-01 08:00 PST, Mark Banner (:standard8)
mconley: review+
Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2011-12-01 04:54:14 PST
+++ This bug was initially created as a clone of Bug #682356 +++

Currently, the AddonRepository APIs for searching (specifically getAddonsByIDs()) automatically send performance metrics to the server.

Per discussion in bug 534956 (implementing add-on sync), having Sync query these APIs will have the undesired effect of skewing the metrics data.

AddonRepository.getAddonsByIDs() should be modified so that it optionally doesn't send performance data as part of the request and Sync can call it without skewing metrics data.

The attached patch adds an argument to getAddonsByIDs() to control sending of performance data. Patch notes:

* I purposefully made the API backwards compatible. Typically callbacks are passed last. I didn't want to go down the refactor hole.
* Note that the lack of an argument defaults to a true value.
* Is the '=== undefined' a suitable replacement for checking the length of the arguments pseudo-array?
* I still need to write the additional tests.
Comment 1 User image Mark Banner (:standard8) 2011-12-01 08:00:49 PST
Created attachment 578266 [details] [diff] [review]
The fix

Ports the change from bug 682356
Comment 2 User image Mike Conley (:mconley) 2011-12-01 08:34:02 PST
Comment on attachment 578266 [details] [diff] [review]
The fix

Looks good to me - thanks,

Comment 3 User image Mark Banner (:standard8) 2011-12-01 11:48:21 PST
Checked in:

Note You need to log in before you can comment on or make changes to this bug.