Make AddonRepository.getAddonsByIDs() not send performance data

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 11.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #682356 +++

Currently, the AddonRepository APIs for searching (specifically getAddonsByIDs()) automatically send performance metrics to the server.

Per discussion in bug 534956 (implementing add-on sync), having Sync query these APIs will have the undesired effect of skewing the metrics data.

AddonRepository.getAddonsByIDs() should be modified so that it optionally doesn't send performance data as part of the request and Sync can call it without skewing metrics data.

The attached patch adds an argument to getAddonsByIDs() to control sending of performance data. Patch notes:

* I purposefully made the API backwards compatible. Typically callbacks are passed last. I didn't want to go down the refactor hole.
* Note that the lack of an argument defaults to a true value.
* Is the '=== undefined' a suitable replacement for checking the length of the arguments pseudo-array?
* I still need to write the additional tests.
(Assignee)

Updated

6 years ago
No longer blocks: 534956
(Assignee)

Updated

6 years ago
tracking-thunderbird11: --- → +
(Assignee)

Comment 1

6 years ago
Created attachment 578266 [details] [diff] [review]
The fix

Ports the change from bug 682356
Attachment #578266 - Flags: review?(mconley)
Comment on attachment 578266 [details] [diff] [review]
The fix

Looks good to me - thanks,

-Mike
Attachment #578266 - Flags: review?(mconley) → review+
(Assignee)

Comment 3

6 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/2ffa45bc67d2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
tracking-thunderbird11: + → ---
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.