707576 - Remove nsIDOMNSElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Got a patch, still need to check if it's ready for review.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 580741 [details] [diff] [review]
Patch v1


>-nsNSElementTearoff::GetFirstElementChild(nsIDOMElement** aResult)
>+nsGenericElement::GetChildElementCount(PRUint32* aResult)
>+{
>+  nsContentList* list = GetChildrenList();
>+  if (!list) {
>+    *aResult = 0;
>+    return NS_ERROR_OUT_OF_MEMORY;
>+  }
>+
>+  *aResult = list->Length(true);
>+  return NS_OK;
>+}
Why OOM check?
Maybe
  *aResult = GetChildrenList()->Length(true);
  return NS_OK;



>+NS_IMETHODIMP
>+nsGenericElement::GetChildElements(nsIDOMNodeList** aResult)
>+{
>+  nsContentList* list = GetChildrenList();
>+  if (!list) {
>+    *aResult = nsnull;
>+    return NS_ERROR_OUT_OF_MEMORY;
>+  }
>+
>+  NS_ADDREF(*aResult = list);
>+  return NS_OK;
>+}
Maybe
  NS_ADDREF(*aResult = GetChildrenList());
  return NS_OK;



> 
>+NS_IMETHODIMP
>+nsGenericElement::GetOnmouseenter(JSContext* cx, JS::Value* vp)
>+{
>+  return nsINode::GetOnmouseenter(cx, vp);
>+}
>+
>+NS_IMETHODIMP
>+nsGenericElement::SetOnmouseenter(JSContext* cx, const JS::Value& v)
>+{
>+  return nsINode::SetOnmouseenter(cx, v);
>+}
>+
>+NS_IMETHODIMP
>+nsGenericElement::GetOnmouseleave(JSContext* cx, JS::Value* vp)
>+{
>+  return nsINode::GetOnmouseleave(cx, vp);
>+}
>+
>+NS_IMETHODIMP
>+nsGenericElement::SetOnmouseleave(JSContext* cx, const JS::Value& v)
>+{
>+  return nsINode::SetOnmouseleave(cx, v);
>+}
Waiting to get answer why this change is needed.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 580741 [details] [diff] [review]
> Patch v1
>
> GetChildrenList

OK, didn't realize this was infallible.

> > 
> >+NS_IMETHODIMP
> >+nsGenericElement::GetOnmouseenter(JSContext* cx, JS::Value* vp)
> >+{
> >+  return nsINode::GetOnmouseenter(cx, vp);
> >+}
> >+
> >+NS_IMETHODIMP
> >+nsGenericElement::SetOnmouseenter(JSContext* cx, const JS::Value& v)
> >+{
> >+  return nsINode::SetOnmouseenter(cx, v);
> >+}
> >+
> >+NS_IMETHODIMP
> >+nsGenericElement::GetOnmouseleave(JSContext* cx, JS::Value* vp)
> >+{
> >+  return nsINode::GetOnmouseleave(cx, vp);
> >+}
> >+
> >+NS_IMETHODIMP
> >+nsGenericElement::SetOnmouseleave(JSContext* cx, const JS::Value& v)
> >+{
> >+  return nsINode::SetOnmouseleave(cx, v);
> >+}
> Waiting to get answer why this change is needed.

Because I used NS_DECL_NSIDOMELEMENT in nsGenericElement.h, I get linking errors if these aren't defined.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 580741 [details] [diff] [review]
Patch v1

Ok.

Fix the OOM cases, r+

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f9f6f9ed788a