Clean up makefile generation in js/src configure

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Similar to the work done in bug 696498 but for js/src configure.

* js/src/lirasm/Makefile.in now longer exists in the tree, so should be removed from configure, since it was causing: "can't read <topsrcdir>/js/src/lirasm/Makefile.in: No such file or directory"
* js/src/analysis-tests/Makefile is missing from configure, so should be added.
* Several of the existing entries should only be generated conditionally, so add conditionals where needed.
(Assignee)

Comment 1

6 years ago
Created attachment 578968 [details] [diff] [review]
Patch v1
Attachment #578968 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

6 years ago
Created attachment 579189 [details] [diff] [review]
Patch v2

As v1 except uses test rather than (the IMO more readable) [ EXPR ] since otherwise autoconf eats the brackets.
Attachment #578968 - Attachment is obsolete: true
Attachment #578968 - Flags: review?(ted.mielczarek)
Attachment #579189 - Flags: review?(ted.mielczarek)
Attachment #579189 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/19d325115037
Flags: in-testsuite-
Target Milestone: --- → mozilla11

Updated

6 years ago
Duplicate of this bug: 707418
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/19d325115037
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.