Closed Bug 707593 Opened 12 years ago Closed 12 years ago

Clean up makefile generation in js/src configure

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
1.63 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Similar to the work done in bug 696498 but for js/src configure.

* js/src/lirasm/Makefile.in now longer exists in the tree, so should be removed from configure, since it was causing: "can't read <topsrcdir>/js/src/lirasm/Makefile.in: No such file or directory"
* js/src/analysis-tests/Makefile is missing from configure, so should be added.
* Several of the existing entries should only be generated conditionally, so add conditionals where needed.
Attached patch Patch v1 (obsolete) — — Splinter Review 

        Attachment #578968 -
        Flags: review?(ted.mielczarek)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2
        — 
          — Splinter Review
      

    


  
As v1 except uses test rather than (the IMO more readable) [ EXPR ] since otherwise autoconf eats the brackets.

        Attachment #578968 -
        Attachment is obsolete: true

        Attachment #578968 -
        Flags: review?(ted.mielczarek)

        Attachment #579189 -
        Flags: review?(ted.mielczarek)

        Attachment #579189 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/19d325115037
Flags: in-testsuite-
Target Milestone: --- → mozilla11

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/19d325115037
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.