Port bug 549561 to Thunderbird to speed up mailbloat tests

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 11.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird9 fixed, thunderbird10 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 579139 [details] [diff] [review]
The fix

I noticed bug 549561 today. By making some changes in trace malloc, they speeded up the time to run the tests.

I've just made a similar modification and pushed to try server - the make mailbloat step on windows dropped from about 2 hours to 2 minutes.

The patch does this by picking up the environment that's defined by automation.py.in (which also picks up the global environment specified by buildbot), and in doing so we gain the NS_TRACE_MALLOC_DISABLE_STACKS preference which is what Firefox has done for its leak test builds.

This modifies the stackwalking in tracemalloc for things we don't need to do unless there's actually issues.

Try server runs all passed with this applied.
Attachment #579139 - Flags: review?(jhopkins)
Comment on attachment 579139 [details] [diff] [review]
The fix

r+ based on this working in try server
Attachment #579139 - Flags: review?(jhopkins) → review+
(Assignee)

Comment 2

5 years ago
This landed and worked: Windows debug builds are now around 30 - 80 mins, where as they were over three hours.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(Assignee)

Comment 3

5 years ago
Comment on attachment 579139 [details] [diff] [review]
The fix

I'm going to take this onto aurora and beta so we can reduce the time of builds there as well and help builder availability.
Attachment #579139 - Flags: approval-comm-beta+
Attachment #579139 - Flags: approval-comm-aurora+
(Assignee)

Comment 4

5 years ago
Trunk changeset was:

http://hg.mozilla.org/comm-central/rev/778c81627f48

Branch changesets:

http://hg.mozilla.org/releases/comm-aurora/rev/b301ba4dfd33
http://hg.mozilla.org/releases/comm-beta/rev/e65027f51cf3
status-thunderbird10: --- → fixed
status-thunderbird9: --- → fixed
You need to log in before you can comment on or make changes to this bug.