Last Comment Bug 708106 - Remove consts for pre 10.4
: Remove consts for pre 10.4
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Hubert Figuiere [:hub]
:
: alexander :surkov
Mentors:
Depends on:
Blocks: maca11y
  Show dependency treegraph
 
Reported: 2011-12-06 14:57 PST by Hubert Figuiere [:hub]
Modified: 2011-12-10 20:42 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
proposed patch (12.97 KB, patch)
2011-12-08 13:46 PST, Hubert Figuiere [:hub]
tbsaunde+mozbugs: review+
surkov.alexander: checkin+
Details | Diff | Splinter Review

Description User image Hubert Figuiere [:hub] 2011-12-06 14:57:32 PST
In mozAccessible.mm we have

const NSString *kInstanceDescriptionAttribute = @"AXDescription";       // NSAccessibilityDescriptionAttribute
const NSString *kTopLevelUIElementAttribute   = @"AXTopLevelUIElement"; // NSAccessibilityTopLevelUIElementAttribute
const NSString *kTextLinkSubrole              = @"AXTextLink";          // NSAccessibilitySecureTextFieldSubrole


These constants are only useful for pre 10.4 SDK. Given that we don't support PPC anymore, it is unlikely we need to build on pre 10.4 SDK.

(I don't have a patch yet)
Comment 1 User image Hubert Figuiere [:hub] 2011-12-06 14:58:13 PST
This is for MacOS X in case it wasn't obvious.
Comment 2 User image Hubert Figuiere [:hub] 2011-12-08 13:46:08 PST
Created attachment 580179 [details] [diff] [review]
proposed patch
Comment 3 User image Trevor Saunders (:tbsaunde) 2011-12-08 20:47:38 PST
Comment on attachment 580179 [details] [diff] [review]
proposed patch

we only support 10.5+

(stealing review unless Alex really wants to) r=tbsaunde
Comment 4 User image Hubert Figuiere [:hub] 2011-12-08 21:08:38 PST
Comment on attachment 580179 [details] [diff] [review]
proposed patch

he'll get the checkin. :-)
Comment 5 User image alexander :surkov 2011-12-08 23:26:10 PST
Comment on attachment 580179 [details] [diff] [review]
proposed patch

inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/4f633a8f0d06
Comment 6 User image Ed Morley [:emorley] 2011-12-10 20:42:43 PST
https://hg.mozilla.org/mozilla-central/rev/4f633a8f0d06

Note You need to log in before you can comment on or make changes to this bug.