The default bug view has changed. See this FAQ.

NoteJSChild shouldn't add children if the non-CCKind node is non-gray

RESOLVED FIXED in mozilla12

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bill noticed that we only skip children when we're non-gray in the AddToCCKind case.  NoteWeakMapChild always does this.  Could be an improvement in some situations.
(Assignee)

Updated

5 years ago
Blocks: 716598
(Assignee)

Comment 1

5 years ago
Created attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray

Mark bits of static strings can be checked now without crashing, so this is pretty simple.
Assignee: nobody → continuation
(Assignee)

Comment 2

5 years ago
Comment on attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray

https://hg.mozilla.org/try/rev/0415ae2b4b8d
Attachment #587069 - Flags: review?(wmccloskey)
Attachment #587069 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

5 years ago
Thanks for the quick review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cef10089737
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/4cef10089737
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.