NoteJSChild shouldn't add children if the non-CCKind node is non-gray

RESOLVED FIXED in mozilla12

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks 1 bug)

Trunk
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

8 years ago
Bill noticed that we only skip children when we're non-gray in the AddToCCKind case.  NoteWeakMapChild always does this.  Could be an improvement in some situations.
Assignee

Updated

8 years ago
Blocks: 716598
Assignee

Comment 1

8 years ago
Mark bits of static strings can be checked now without crashing, so this is pretty simple.
Assignee: nobody → continuation
Assignee

Comment 2

8 years ago
Comment on attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray

https://hg.mozilla.org/try/rev/0415ae2b4b8d
Attachment #587069 - Flags: review?(wmccloskey)
Attachment #587069 - Flags: review?(wmccloskey) → review+
Assignee

Comment 3

8 years ago
Thanks for the quick review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cef10089737
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/4cef10089737
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.