Last Comment Bug 708322 - NoteJSChild shouldn't add children if the non-CCKind node is non-gray
: NoteJSChild shouldn't add children if the non-CCKind node is non-gray
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on:
Blocks: 716598
  Show dependency treegraph
 
Reported: 2011-12-07 10:54 PST by Andrew McCreight [:mccr8]
Modified: 2012-01-10 18:49 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
return immediately if JS thing is non-gray (2.00 KB, patch)
2012-01-09 12:03 PST, Andrew McCreight [:mccr8]
wmccloskey: review+
Details | Diff | Review

Description Andrew McCreight [:mccr8] 2011-12-07 10:54:43 PST
Bill noticed that we only skip children when we're non-gray in the AddToCCKind case.  NoteWeakMapChild always does this.  Could be an improvement in some situations.
Comment 1 Andrew McCreight [:mccr8] 2012-01-09 12:03:49 PST
Created attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray

Mark bits of static strings can be checked now without crashing, so this is pretty simple.
Comment 2 Andrew McCreight [:mccr8] 2012-01-09 12:37:26 PST
Comment on attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray

https://hg.mozilla.org/try/rev/0415ae2b4b8d
Comment 3 Andrew McCreight [:mccr8] 2012-01-10 09:53:45 PST
Thanks for the quick review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cef10089737
Comment 4 Ed Morley [:emorley] 2012-01-10 18:49:55 PST
https://hg.mozilla.org/mozilla-central/rev/4cef10089737

Note You need to log in before you can comment on or make changes to this bug.