70852 - leaks in composing and sending

Status: VERIFIED WORKSFORME

(MailNews Core :: Composition, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Even after my fix to bug 66887, composing and sending a message still leaks a
bit.  This looks like there are a bunch of small leaks.  They probably aren't
too hard to find with the refcount logging tools (see
<URL: http://mozilla.org/performance/leak-tutorial.html >) and fix, but I don't
have time to do it.

There seem to be leaks associated both with editing and sending a message,
although the former could instead be associated with the "Don't Send" prompt. 
I'll attach some leak logs:

1) leaks with './mozilla -compose' and then closing the window with the 'X'
2) './mozilla -compose', type in body of message, close window with 'X', click
"Don't Send"
3) './mozilla -compose', type in address, subject, and body, and send message

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: (1) leaks after './mozilla -compose' and exit with "X"

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: (1) leaks after './mozilla -compose', typing in body, "X", "Don't Send"

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: (3) leaks after './mozilla -compose', typing in address, subject, and body, and Sending

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To clarify, the leaks in (1) aren't the ones I'm worried about.  This bug is
about the differences between (1) and (2) and the differences between (1) and (3).

Comment 5

[Dimitrios]

Isn't this a Platform->All issue ? Message creation and sending is leaking like
hell (more than 1 MB, each time). I hope I 'll manage to setup Purify in order
to detect those leaks.

Comment 6

[David :Bienvenu]

plussing, need to fix this.

Comment 7

[Jean-Francois Ducarroz]

Those leak you report are too generic. They could be anywere in the code! We
know that any window or dialog leak like hell (but the situation should be
better now). We are currently fixing a lot of leaks in mailnews (by the way that
are not report in the bloat are the mailnews class are not registered!) using
Purify which pin point the exact location of the leak. If you don't mind, I
would like to close this bug as invalid and instead concentrate our effort on
those leak we have identified with Purify

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think all the sizable leaks in the reports above except the one-time leak
related to the JS component are fixed now, or at least were when I looked a week
or two ago.  bug 99180 helped a bit, and there's a bug on the JS component stuff
somewhere (filed recently)

Comment 9

[Jean-Francois Ducarroz]

I am closing this bug as works for me per reporter comment.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

verified per dbaron's comments.  I'll continue to file leaks as needed.