708640 - Should be able to open a new tab by middle-clicking the "Go" button.

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, enhancement)

Description

[Philip Chee]

Relevant Firefox bugs:
  [Bug 279687] Should be able to open new tab by middle-clicking "Go" button.
  [Bug 339710] Can't use "Go" button" with using keyword or space.
  [Bug 405541] Location Bar don't revert back to the correct url of the tab when you middle click go after entering text, to open in a new tab.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 checkForMiddleClick.

Is this the right approach?

Comment 2

[[e-mail]]

Does Ctrl+Clicking the "Go" button already work? I think that uses an earlier code block, might be worth seeing whether we can hook into that instead.

Comment 3

[[e-mail]]

Comment on attachment 580060 [details] [diff] [review]
Patch v1.0 checkForMiddleClick.

>+      var where = whereToOpenLink(aTriggeringEvent, false, false);
Indeed, this is wrong because it uses the wrong pref. Instead you need to look for a potential button 1 in the original conditional block.

>+                onclick="checkForMiddleClick(this, event);"
This part of the patch is fine of course.

Comment 4

[Philip Chee]

Attachment: Patch v1.1 Use existing code block.

> Does Ctrl+Clicking the "Go" button already work? I think that uses an earlier
> code block, might be worth seeing whether we can hook into that instead.
Fixed.

> Comment on attachment 580060 [details] [diff] [review]
> Patch v1.0 checkForMiddleClick.
> 
>>+      var where = whereToOpenLink(aTriggeringEvent, false, false);
> Indeed, this is wrong because it uses the wrong pref. Instead you need to look
> for a potential button 1 in the original conditional block.
Fixed.

>>+                onclick="checkForMiddleClick(this, event);"
> This part of the patch is fine of course.
Phew.

Comment 5

[[e-mail]]

Comment on attachment 580347 [details] [diff] [review]
Patch v1.1 Use existing  code block.

>         (('ctrlKey' in aTriggeringEvent && aTriggeringEvent.ctrlKey) ||
>-         ('metaKey' in aTriggeringEvent && aTriggeringEvent.metaKey))) {
>+         ('metaKey' in aTriggeringEvent && aTriggeringEvent.metaKey) ||
>+         (aTriggeringEvent instanceof MouseEvent && aTriggeringEvent.button == 1))) {
Would you mind using the same style as the other conditions?

Comment 6

[Philip Chee]

Attachment: Patch v1.2 Patch as checked in.

>>         (('ctrlKey' in aTriggeringEvent && aTriggeringEvent.ctrlKey) ||
>>-         ('metaKey' in aTriggeringEvent && aTriggeringEvent.metaKey))) {
>>+         ('metaKey' in aTriggeringEvent && aTriggeringEvent.metaKey) ||
>>+         (aTriggeringEvent instanceof MouseEvent && aTriggeringEvent.button == 1))) {
> Would you mind using the same style as the other conditions?
Done.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/3d2c908c2938