708754 - Use IDL for jsdIDebuggerService::WrapValue and remove WrapJSValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

We can get rid of the nsAXPCNativeCallContext stuff, and WrapJSValue becomes rather redundant after that.

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 580119 [details] [diff] [review]
Patch v1


>-          nsCOMPtr<jsdIValue> jsdValue;
>-          jsd->WrapJSValue(v, getter_AddRefs(jsdValue));
>-          *aRetVal = jsdValue.forget().get();
>+          nsRefPtr<jsdIValue> jsdValue;
>+          rv = jsd->WrapValue(v, getter_AddRefs(jsdValue));
>+          NS_ENSURE_SUCCESS(rv, rv);
>+          jsdValue.forget(aRetVal);

Why the switch from nsCOMPtr to nsRefPtr here?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Because nsCOMPtr::forget can only be called with T**, while nsRefPtr's version is happy with superclasses. (Yes, silly, I know; that's Gecko for you.)

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 580119 [details] [diff] [review]
Patch v1

(In reply to Ms2ger from comment #2)
> Because nsCOMPtr::forget can only be called with T**, while nsRefPtr's
> version is happy with superclasses. (Yes, silly, I know; that's Gecko for
> you.)

Hm, in that case I'd rather fix nsCOMPtr (looks like it just needs a template<typename I>), or failing that use the slightly more awkward syntax we had here before. We might as well use COM pointers for COM objects.

r+ once that's taken care of.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/21fbcd2f27a8

d-d-n in case anybody used WrapJSValue.