Support nsCOMPtr<T>::forget(I**)

RESOLVED FIXED in mozilla11

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 580873 [details] [diff] [review]
Patch v1

As in bug 489705.
Attachment #580873 - Flags: review?(benjamin)
Attachment #580873 - Flags: review?(benjamin) → review+
I love you.
Comment on attachment 580873 [details] [diff] [review]
Patch v1

Wait, the reason the old code called swap on a temp ptr was for comptr logging. Your current patch skips all that. Are you sure this won't mess up the comptr logging scripts?
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/82bc89d8e3c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Ms2ger, you didn't address comment 2. Do our leak scripts handle this?
(Assignee)

Comment 5

5 years ago
No idea.
Yeah, I think this needs to use NSCAP_LOG_RELEASE to make nsCOMPtr logging work again.
Created attachment 637311 [details] [diff] [review]
Fix the COMPtr logging
Attachment #637311 - Flags: review?(dbaron)
Comment on attachment 637311 [details] [diff] [review]
Fix the COMPtr logging

r=dbaron
Attachment #637311 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/027b86239bf3
Er, ugh, now that I look again, we shouldn't have made the second change, since nsCOMPtr<nsISupports>::forget(nsISupports**) uses swap().
Previous patch half backed out in https://hg.mozilla.org/mozilla-central/rev/f08d285b63b0 , so things should now be good.
You need to log in before you can comment on or make changes to this bug.