Created attachment 580873 [details] [diff] [review] Patch v1 As in bug 489705.
I love you.
Comment on attachment 580873 [details] [diff] [review] Patch v1 Wait, the reason the old code called swap on a temp ptr was for comptr logging. Your current patch skips all that. Are you sure this won't mess up the comptr logging scripts?
Ms2ger, you didn't address comment 2. Do our leak scripts handle this?
Yeah, I think this needs to use NSCAP_LOG_RELEASE to make nsCOMPtr logging work again.
Created attachment 637311 [details] [diff] [review] Fix the COMPtr logging
Comment on attachment 637311 [details] [diff] [review] Fix the COMPtr logging r=dbaron
Er, ugh, now that I look again, we shouldn't have made the second change, since nsCOMPtr<nsISupports>::forget(nsISupports**) uses swap().
Previous patch half backed out in https://hg.mozilla.org/mozilla-central/rev/f08d285b63b0 , so things should now be good.