Closed Bug 709747 Opened 14 years ago Closed 14 years ago

Support nsCOMPtr<T>::forget(I**)

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(2 files)

Attached patch Patch v1Splinter Review
As in bug 489705.
Attachment #580873 - Flags: review?(benjamin)
Attachment #580873 - Flags: review?(benjamin) → review+
Comment on attachment 580873 [details] [diff] [review] Patch v1 Wait, the reason the old code called swap on a temp ptr was for comptr logging. Your current patch skips all that. Are you sure this won't mess up the comptr logging scripts?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Ms2ger, you didn't address comment 2. Do our leak scripts handle this?
No idea.
Yeah, I think this needs to use NSCAP_LOG_RELEASE to make nsCOMPtr logging work again.
Comment on attachment 637311 [details] [diff] [review] Fix the COMPtr logging r=dbaron
Attachment #637311 - Flags: review?(dbaron) → review+
Er, ugh, now that I look again, we shouldn't have made the second change, since nsCOMPtr<nsISupports>::forget(nsISupports**) uses swap().
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: