Closed Bug 708774 Opened 8 years ago Closed 8 years ago

Make landscape keyboard be fullscreen

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox13 --- verified

People

(Reporter: mfinkle, Assigned: mbrubeck)

References

Details

(Keywords: inputmethod, Whiteboard: [VKB][not-fennec-11])

Attachments

(1 file)

There is not enough space in landscape to show the keyboard and content at the same time. Some may argue we could try real hard to make more space, but it's not worth it.

When we are in landscape, let's use the fullscreen keyboard.
Whiteboard: [VKB]
This looks fixed in tinderbox build.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Oops.  I tried the about:config text box and it was not full screen there.  Nor at www.google.com.  Closed too early.  URL bar is fullscreen though.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
I've found that after the recent major change the full-screen UI is not working, I'm looking into that.

What else is involved in this except setting the preference?
Keywords: inputmethod
OS: Linux → Android
Hardware: x86 → ARM
Depends on: 714950
Attached patch patchSplinter Review
Just setting the pref seems to be sufficient.
Attachment #586477 - Flags: review?(mark.finkle)
Comment on attachment 586477 [details] [diff] [review]
patch

this shouldn't affect tablets
Attachment #586477 - Flags: review?(mark.finkle) → review+
This can't land until the blocking bug 714950 is fixed.

(In reply to Mark Finkle (:mfinkle) from comment #5)
> this shouldn't affect tablets

Actually, this patch will *only* affect devices with 5" or larger displays (approximately), like the 7" Galaxy Tab.  If you were seeing non-fullscreen keyboards on a smaller device, then this patch might not fix the problem.  On what devices can you reproduce this bug?
Whiteboard: [VKB] → [VKB][waiting for blocker 714950]
I get full-screen keyboard right now on the Nexus S which is 4".
Right, that's expected.  The "bug" here is that some devices show a *non-fullscreen* keyboard.

Current behavior (without patch): Fullscreen keyboard when available on devices less than about 5", non-fullscreen keyboard on devices greater than about 5".

New behavior (with patch): Fullscreen keyboard when available on all devices.  (Some devices like honeycomb tablets do not have a full-screen keyboard mode.)
tracking-fennec: --- → 11+
Does this need anything else?
Whiteboard: [VKB][waiting for blocker 714950] → [VKB]
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ec894d6c37c

I don't think we need this on Aurora.  It's a very minor tweak that affects only a small minority of devices (certain 5" to 7" tablets) and is unlikely to cause merge conflicts.  Please re-nominate if you disagree.
Status: NEW → ASSIGNED
tracking-fennec: 11+ → ---
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/0ec894d6c37c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Matt, please request aurora approval
Marking as not-fennec-11; see comment 10 for rationale.
Whiteboard: [VKB] → [VKB][not-fennec-11]
Comment on attachment 586477 [details] [diff] [review]
patch

[Triage Comment]
Attachment #586477 - Flags: approval-mozilla-beta+
Verified fixed on:

Firefox 13.0a1 (2012-03-02)
20120302031112
http://hg.mozilla.org/mozilla-central/rev/3a7b9e61c263

--
Device: Samsung Galaxy S2
OS: Android 2.3.4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.