Unable to see characters typed in landscape fullscreen VKB

VERIFIED FIXED in Firefox 11

Status

()

defect
P2
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: aaronmt, Assigned: alexp)

Tracking

({inputmethod, regression})

Trunk
Firefox 12
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

(Whiteboard: [VKB], )

Attachments

(3 attachments, 1 obsolete attachment)

Reporter

Description

8 years ago
On the bug URL: http://mail.yahoo.com, rotating device to landscape any input I enter into the fields 'Yahoo! ID' or 'Password' is not displayed in the edit-box of the virtual-keyboard. This looks like a regression.
Reporter

Comment 1

8 years ago
Tested on:
Motorola Droid Pro (Android 2.3)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120103 Firefox/12.0a1 Fennec/12.0a1
Assignee

Comment 2

8 years ago
This is a more general issue. The problem is with native fullscreen keyboard UI. As I already mentioned in the bug 708774 it was broken by the recent major change to the GeckoInputConnection class. The input handling has been significantly simplified to fix the issues we had, but that caused some side-effects.
I am working on this.
Assignee: nobody → alexp
Blocks: 708774
Status: NEW → ASSIGNED
Summary: [VKB] - Unable to see characters typed in VKB under landscape on the Droid Pro → Unable to see characters typed in landscape fullscreen VKB
Assignee

Comment 3

8 years ago
(In reply to Alex Pakhotin (:alexp) from comment #2)
> it was broken by the recent major change to the GeckoInputConnection class.

For the record - that was bug 595008, so it's a known point of regression.
happens on Galaxy Nexus, both Aurora and Nightly.  2012-01-04 build, 11.0a2 and 12.0a1

Repro'd on google.com
Posted image screenshot on SGS2
surprisingly, i can't reproduce on my SGS2, android 2.3.3
Assignee

Comment 6

8 years ago
(In reply to Tony Chung [:tchung] from comment #5)
> Created attachment 585973 [details]
> screenshot on SGS2
> 
> surprisingly, i can't reproduce on my SGS2, android 2.3.3

This is not a fullscreen VKB. The problem we have is only with so called "extracted text UI" - when IME opens its own UI with an edit box, which covers the application completely.
Priority: -- → P2
Duplicate of this bug: 715993
tracking-fennec: --- → 11+
Assignee

Comment 8

8 years ago
Posted patch Fix (obsolete) — Splinter Review
Update extracted text UI on the content changes.

The patch also contains some debug output tweaking for GeckoInputConnection.
Attachment #586631 - Flags: review?(blassey.bugs)
Comment on attachment 586631 [details] [diff] [review]
Fix

Review of attachment 586631 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoInputConnection.java
@@ +210,5 @@
> +
> +        return setSelectionInternal(start, end);
> +    }
> +
> +    private boolean setSelectionInternal(int start, int end) {

why do we need setSelectionInternal()? just call super.setSelection() in setSelection();
Assignee

Comment 10

8 years ago
(In reply to Brad Lassey [:blassey] from comment #9)

> why do we need setSelectionInternal()? just call super.setSelection() in
> setSelection();

It is also called from notifySelectionChange(). I wanted to add a method, which does stuff specific to this subclass, but without calling Gecko. Right now it simply calls the super class. Of course could call super.setSelection() directly in both places - I wasn't quite sure what would be better, an extra layer just seemed a bit safer for the future.
Assignee

Comment 11

8 years ago
Posted patch Fix v2Splinter Review
Got rid of setSelectionInternal().
Attachment #586631 - Attachment is obsolete: true
Attachment #586631 - Flags: review?(blassey.bugs)
Attachment #587572 - Flags: review?(blassey.bugs)
Comment on attachment 587572 [details] [diff] [review]
Fix v2

Review of attachment 587572 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoInputConnection.java
@@ +629,3 @@
>          switch (type) {
>          case NOTIFY_IME_RESETINPUTSTATE:
> +            if (DEBUG) Log.d(LOGTAG, ". . . notifyIME: reset");

why change this logging?

@@ +650,5 @@
>              IMEStateUpdater.enableIME();
>              break;
>  
>          case NOTIFY_IME_CANCELCOMPOSITION:
> +            if (DEBUG) Log.d(LOGTAG, ". . . notifyIME: cancel");

why change this logging?

@@ +655,5 @@
>              IMEStateUpdater.resetIME();
>              break;
>  
>          case NOTIFY_IME_FOCUSCHANGE:
> +            if (DEBUG) Log.d(LOGTAG, ". . . notifyIME: focus");

why change this logging?
Attachment #587572 - Flags: review?(blassey.bugs) → review+
Assignee

Comment 13

8 years ago
(In reply to Brad Lassey [:blassey] from comment #12)
> >          switch (type) {
> >          case NOTIFY_IME_RESETINPUTSTATE:
> > +            if (DEBUG) Log.d(LOGTAG, ". . . notifyIME: reset");

It's just for consistency with other similar logging in this class, and better readability of the debug log.
https://hg.mozilla.org/mozilla-central/rev/939f9467fc73
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Duplicate of this bug: 718243
Verified fixed in today's build.
Status: RESOLVED → VERIFIED
Comment on attachment 587572 [details] [diff] [review]
Fix v2

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
typed chars can't be seen in landscape mode
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
regressions for untested IMEs
Attachment #587572 - Flags: approval-mozilla-aurora?
Comment on attachment 587572 [details] [diff] [review]
Fix v2

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587572 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.