Last Comment Bug 709182 - "connecting" in tab title when reloading is unnecessary visual noise
: "connecting" in tab title when reloading is unnecessary visual noise
Status: RESOLVED FIXED
[Snappy:P1]
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Firefox 13
Assigned To: Jared Wein [:jaws] (please needinfo? me)
:
: Dão Gottwald [:dao]
Mentors:
: 481356 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-09 10:25 PST by Dietrich Ayala (:dietrich)
Modified: 2012-08-12 15:48 PDT (History)
12 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch for bug (1.35 KB, patch)
2012-02-14 21:43 PST, Jared Wein [:jaws] (please needinfo? me)
ttaubert: review+
dao+bmo: review+
Details | Diff | Splinter Review

Description Dietrich Ayala (:dietrich) 2011-12-09 10:25:51 PST
Limi: "connecting" in the title of a tab while reloading should be removed, it's visual noise that makes it seem slower.
Comment 1 Jared Wein [:jaws] (please needinfo? me) 2012-02-14 21:43:13 PST
Created attachment 597297 [details] [diff] [review]
Patch for bug

I need to push it to tryserver tomorrow, as I'm pretty sure this will break some tests.
Comment 2 Mozilla RelEng Bot 2012-02-14 21:48:12 PST
Autoland Patchset:
	Patches: 597297
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=27dfc588401d
Try run started, revision 27dfc588401d. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=27dfc588401d
Comment 3 Mozilla RelEng Bot 2012-02-15 02:00:21 PST
Try run for 27dfc588401d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=27dfc588401d
Results (out of 211 total builds):
    success: 181
    warnings: 16
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-27dfc588401d
Comment 4 Jared Wein [:jaws] (please needinfo? me) 2012-02-15 09:39:58 PST
Comment on attachment 597297 [details] [diff] [review]
Patch for bug

The try run was green, so I'm moving this forward for review.
Comment 5 Tim Taubert [:ttaubert] 2012-02-15 10:56:35 PST
Comment on attachment 597297 [details] [diff] [review]
Patch for bug

Review of attachment 597297 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I'm not too familiar with this code. Asking Dão for review to be on the safe side here.
Comment 6 Jared Wein [:jaws] (please needinfo? me) 2012-02-15 17:16:46 PST
https://hg.mozilla.org/integration/fx-team/rev/f2267cb4330f
Comment 7 Tim Taubert [:ttaubert] 2012-02-16 03:56:36 PST
https://hg.mozilla.org/mozilla-central/rev/f2267cb4330f
Comment 8 Dão Gottwald [:dao] 2012-08-12 12:24:18 PDT
*** Bug 481356 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.