Remove dead editor code

RESOLVED FIXED in mozilla11

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

(Assignee)

Description

6 years ago
Created attachment 580681 [details] [diff] [review]
Part a: nsDOMSubtreeIterator::Init

Because there's so much of it I'm not going to file a bug per patch.
Attachment #580681 - Flags: review?(ehsan)
(Assignee)

Comment 1

6 years ago
Created attachment 580682 [details] [diff] [review]
Part b: nsDOMIterator::ForEach
Attachment #580682 - Flags: review?(ehsan)
(Assignee)

Comment 2

6 years ago
Created attachment 580683 [details] [diff] [review]
Part c: EditAggregateTxn::{GetCount,GetTxnAt,SetName}
Attachment #580683 - Flags: review?(ehsan)
(Assignee)

Comment 3

6 years ago
Created attachment 580684 [details] [diff] [review]
Part d: nsHTMLEditor::IsRootTag
Attachment #580684 - Flags: review?(ehsan)
(Assignee)

Comment 4

6 years ago
Created attachment 580685 [details] [diff] [review]
Part e: Some overloads of TypeInState::{SetProp,ClearProp}
Attachment #580685 - Flags: review?(ehsan)
(Assignee)

Comment 5

6 years ago
Created attachment 580686 [details] [diff] [review]
Part f: nsHTMLEditUtils::IsAddress
Attachment #580686 - Flags: review?(ehsan)
(Assignee)

Comment 6

6 years ago
Created attachment 580687 [details] [diff] [review]
Part g: nsHTMLEditRules::{Will,Did}DeleteRange
Attachment #580687 - Flags: review?(ehsan)
(Assignee)

Comment 7

6 years ago
Created attachment 580740 [details] [diff] [review]
Part h: Unused variable in nsHTMLEditor::GetBodyElement
Attachment #580740 - Flags: review?(ehsan)
Attachment #580681 - Flags: review?(ehsan) → review+
Attachment #580682 - Flags: review?(ehsan) → review+
Attachment #580683 - Flags: review?(ehsan) → review+
Attachment #580684 - Flags: review?(ehsan) → review+
Attachment #580685 - Flags: review?(ehsan) → review+
Comment on attachment 580686 [details] [diff] [review]
Part f: nsHTMLEditUtils::IsAddress

So, we were including a hear for bool!  Nice :P
Attachment #580686 - Flags: review?(ehsan) → review+
Attachment #580687 - Flags: review?(ehsan) → review+
Attachment #580740 - Flags: review?(ehsan) → review+
Nice work, thanks Ms2ger!
(Assignee)

Comment 10

6 years ago
Thanks for the reviews!

https://hg.mozilla.org/mozilla-central/rev/cd7bd3b20de0
https://hg.mozilla.org/mozilla-central/rev/b9e76ec6ac89
https://hg.mozilla.org/mozilla-central/rev/9c4cd94a11d7
https://hg.mozilla.org/mozilla-central/rev/6b33453c5a4f
https://hg.mozilla.org/mozilla-central/rev/faf5d722417b
https://hg.mozilla.org/mozilla-central/rev/77b565997e66
https://hg.mozilla.org/mozilla-central/rev/3d6f670f417f
https://hg.mozilla.org/mozilla-central/rev/ab91118be560
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.