Closed Bug 709709 Opened 8 years ago Closed 8 years ago

Remove unused nsDragService::GetShellVersion

Categories

(Core :: Widget: Win32, defect)

x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: m_kato, Assigned: m_kato)

References

()

Details

Attachments

(1 file)

This is unused.  We should remove this.


http://mxr.mozilla.org/mozilla-central/ident?i=GetShellVersion

    widget/src/windows/nsDragService.cpp (View Hg log or Hg annotations)
        line 616, as member of class nsDragService -- PRUint64 nsDragService::GetShellVersion() 

Defined as a function prototype in:

    widget/src/windows/nsDragService.h (View Hg log or Hg annotations)
        line 89 -- PRUint64 GetShellVersion(); 

Defined as a variable in:

    mobile/xul/chrome/content/Util.js (View Hg log or Hg annotations)
        line 182 -- let shellVersion = sysInfo.get("shellVersion") || ""; 

Referenced (in 2 files total) in:

    xpcom/base/nsSystemInfo.cpp (View Hg log or Hg annotations)
        line 201 -- SetPropertyAsAString(NS_LITERAL_STRING("shellVersion"), str); 
    mobile/xul/chrome/content/Util.js (View Hg log or Hg annotations)
        line 183 -- let matches = shellVersion.match(/\((\d+)\)$/);
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Attachment #580854 - Flags: review?(jmathies)
Comment on attachment 580854 [details] [diff] [review]
fix

This looks fine. From the shellVersion code in sys info, it looks like this is only in use on Android?

(More bug 709193 work.)
Attachment #580854 - Flags: review?(jmathies) → review+
Blocks: deadcode
(In reply to Jim Mathies [:jimm] from comment #2)
> Comment on attachment 580854 [details] [diff] [review]
> fix
> 
> This looks fine. From the shellVersion code in sys info, it looks like this
> is only in use on Android?
> 
> (More bug 709193 work.)

Yes.

Also nsDragService::GetShellVersion() into windows widget is used on Gecko 1.9.2, but this is no longer used on Gecko 2.0 or later
https://hg.mozilla.org/mozilla-central/rev/f16d056c532b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.