Closed Bug 709718 Opened 8 years ago Closed 8 years ago

Vertical lines between off-time hours have the wrong color

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Paenglab)

Details

(Whiteboard: [good first bug])

Attachments

(3 files)

(In reply to Decathlon from bug 698760 comment 8)
> In the rotated view, in the time bar, the vertical lines between the "off-time" 
> hours are white (or missing) instead of gray.

These lines should be fixed and given an appropriate color.
With removing the -moz-border-right-colors the right color is shown again.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #581313 - Flags: review?(bv1578)
Unbitrotted patch
Attachment #581313 - Attachment is obsolete: true
Attachment #581313 - Flags: review?(bv1578)
Attachment #586731 - Flags: review?(bv1578)
Comment on attachment 586731 [details] [diff] [review]
Give back the color v2

The same should be done for the code inside the selectors with the window[systemcolors] rule (maybe a separate patch for comm-central?)

I've also noticed that in rotate view and with the setting for the optimized color activated, there are some lines with different colors (see next screenshot). An issue from bug 671119, but maybe you could fix it here without opening another bug.
Attachment #586731 - Flags: review?(bv1578) → review+
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/1ab3229278a6
Target Milestone: --- → 1.4
(In reply to Decathlon from comment #3)
> Comment on attachment 586731 [details] [diff] [review]
> Give back the color v2
> 
> The same should be done for the code inside the selectors with the
> window[systemcolors] rule (maybe a separate patch for comm-central?)

Fixed with the check-in.

(In reply to Decathlon from comment #4)
> Created attachment 586807 [details]
> some different lines in rotate view with optimized colors setting activated

Also fixed.
Comment on attachment 581313 [details] [diff] [review]
Give back the color

Do you give approval for aurora and maybe beta (only for the initial issue)?

Bug 698760 who introduced this issue has Target Milestone: 1.0b8
Attachment #581313 - Attachment is obsolete: false
Attachment #581313 - Flags: feedback?(philipp)
Comment on attachment 581313 [details] [diff] [review]
Give back the color

Since this is super low risk, lets take it for beta.
Attachment #581313 - Flags: feedback?(philipp) → feedback+
Pushed to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/9907a8d0e3a6>
Target Milestone: 1.4 → 1.3
Pushed to comm-beta: <http://hg.mozilla.org/releases/comm-beta/rev/9f92db34aff0>
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: 1.3 → 1.2
You need to log in before you can comment on or make changes to this bug.