Calendar Views UI freshening

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Sunbird 1.0b1
Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [needed beta][no l10n impact])

Attachments

(1 attachment)

I have some cool new colors and style changes for the calendar views coming up. This gives Lightning 1.0 the extra kicks and makes it look delicious!
Flags: blocking-calendar1.0+
attachment 569089 [details] is how it looks like under gnome. I've ported the changes to mac and added some extra flavor, now I just need to make sure it looks as expected under windows. Expect a patch in the evening.

I'd appreciate a ui-review on attachment attachment 569089 [details] and of course a review on the patch in the evening.
Created attachment 571020 [details] [diff] [review]
Preview - v1

Here is a preview, it should work on all platforms but is untested on windows.
Comment on attachment 571020 [details] [diff] [review]
Preview - v1

On Windows it looks good too.

You removed the use of calendar-day-label-back.png, calendar-day-label-back-vertical.png, gradient-overlay.png and category-overlay.png but leaved the files in the tree (and finally also in the XPI). Is this intended?

You are also not consistent in using spaces after commas, like this in the same line and also on other places:
+    background-image: -moz-linear-gradient(top,rgba(255, 255, 255, 0.25), rgba(255, 255, 255, 0.01) 50%, rgba(0,0,0,0.05))

r+ with those fixed or an explanation why it is like it is ;)
Attachment #571020 - Flags: review+
(In reply to Richard Marti [:paenglab] from comment #3)
> Comment on attachment 571020 [details] [diff] [review] [diff] [details] [review]
> Preview - v1
> 
> On Windows it looks good too.
I noticed selection in the today pane is not as expected, I'll fix this too.

> 
> You removed the use of calendar-day-label-back.png,
> calendar-day-label-back-vertical.png, gradient-overlay.png and
> category-overlay.png but leaved the files in the tree (and finally also in
> the XPI). Is this intended?
No, I just forgot to remove them in the patch, thanks for the note!

> 
> You are also not consistent in using spaces after commas, like this in the
> same line and also on other places:
> +    background-image: -moz-linear-gradient(top,rgba(255, 255, 255, 0.25),
> rgba(255, 255, 255, 0.01) 50%, rgba(0,0,0,0.05))
Thanks, I'll fix that before checkin.

> 
> r+ with those fixed or an explanation why it is like it is ;)
Pushed to comm-central changeset b519ca5ae1f2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to releases/comm-aurora changeset 3aca88ef7883
Target Milestone: Trunk → 1.0b9
Backported to releases/comm-beta changeset cefa766b7b7f
Target Milestone: 1.0b9 → 1.0b8

Comment 8

7 years ago
Philipp, there is a minor issue:
in rotate view, in the time bar, the vertical lines between the "off-time" hours are white (or missing) instead of gray.

Considerations:
1. the double border on the right side of the time-bar (week/day view) now is present also beside the allday and weekday column headers, is it a wanted detail?

2. in month/multiweek view there is 4 pixels room between the event boxes, might it be too much space (before, it was 2 pixels)?

3. the blue date bar in the "today" day (month/multiweek view) when today is the selected day, was proposed but criticized in bug 514226 comment #6 because when the day box is full of events the background is hidden and it's difficult to recognize the selected day color.
(In reply to Decathlon from comment #8)
> Philipp, there is a minor issue:
> in rotate view, in the time bar, the vertical lines between the "off-time"
> hours are white (or missing) instead of gray.
Ah ok, I had the impression that this was done on purpose, but I'm good with removing that.

> 
> Considerations:
> 1. the double border on the right side of the time-bar (week/day view) now
> is present also beside the allday and weekday column headers, is it a wanted
> detail?
Yes, I wanted the double line to go through from bottom to top

> 
> 2. in month/multiweek view there is 4 pixels room between the event boxes,
> might it be too much space (before, it was 2 pixels)?
Not on purpose, we should get rid of this

> 3. the blue date bar in the "today" day (month/multiweek view) when today is
> the selected day, was proposed but criticized in bug 514226 comment #6
> because when the day box is full of events the background is hidden and it's
> difficult to recognize the selected day color.
I think you referenced the wrong bug here? Maybe you could doublecheck. I understand that reasoning, but on the other hand when an event is selected its hard to see the today. The border helps, but I think it just doesn't quite cut it. Maybe we can find an alternative here.


I think we should fix these issues in new bugs though.
Target Milestone: 1.0 → ---
Version: unspecified → Sunbird 1.0b1

Comment 10

7 years ago
> > 3. the blue date bar in the "today" day (month/multiweek view) when today is
> > the selected day, was proposed but criticized in bug 514226 comment #6
> > because when the day box is full of events the background is hidden and it's
> > difficult to recognize the selected day color.
> I think you referenced the wrong bug here? Maybe you could doublecheck. I
> understand that reasoning, but on the other hand when an event is selected
> its hard to see the today. The border helps, but I think it just doesn't
> quite cut it. Maybe we can find an alternative here.
> 

Opss. Sorry, I meant bug 455045 comment #6.
I agree with your solution (in bug 455045 I proposed the same) but indeed the visibility of the selected day could be a problem.
Solutions might be either a darker border for the "today" day or a thicker border (or both). These are requests I saw on Bugzilla.
What about the mentioned new bugs for the issues from comment#9?
(In reply to Philipp Kewisch [:Fallen] from comment #9)
> (In reply to Decathlon from comment #8)
> > Philipp, there is a minor issue:
> > in rotate view, in the time bar, the vertical lines between the "off-time"
> > hours are white (or missing) instead of gray.
> Ah ok, I had the impression that this was done on purpose, but I'm good with
> removing that.
Filed bug 709718

> > 2. in month/multiweek view there is 4 pixels room between the event boxes,
> > might it be too much space (before, it was 2 pixels)?
> Not on purpose, we should get rid of this
I believe Decathlon had a grip on this in another bug? Decathlon, maybe you could comment on this and/or file a new bug.


> > 3. the blue date bar in the "today" day (month/multiweek view) when today is
> > the selected day, was proposed but criticized in bug 514226 comment #6
> > because when the day box is full of events the background is hidden and it's
> > difficult to recognize the selected day color.
> I think you referenced the wrong bug here? Maybe you could doublecheck. I
> understand that reasoning, but on the other hand when an event is selected
> its hard to see the today. The border helps, but I think it just doesn't
> quite cut it. Maybe we can find an alternative here.
Lets just wait until we have major gripes here. Since we now have extra room on the sides of events, I think its ok.
(Assignee)

Updated

7 years ago
Blocks: 516174
You need to log in before you can comment on or make changes to this bug.