Last Comment Bug 710103 - Update XPCShell tests for GfxInfo blocklisting
: Update XPCShell tests for GfxInfo blocklisting
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Doug Sherk (:drs) (inactive)
:
Mentors:
Depends on:
Blocks: 706702
  Show dependency treegraph
 
Reported: 2011-12-12 18:27 PST by Doug Sherk (:drs) (inactive)
Modified: 2012-03-08 15:10 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1.0, update XPCShell tests for GfxInfo blocklisting. (50.77 KB, patch)
2011-12-13 00:41 PST, Doug Sherk (:drs) (inactive)
joe: review+
Details | Diff | Splinter Review
Patch v1.1, update XPCShell tests for GfxInfo blocklisting. (49.60 KB, patch)
2011-12-13 20:37 PST, Doug Sherk (:drs) (inactive)
bugzilla: review+
Details | Diff | Splinter Review

Description Doug Sherk (:drs) (inactive) 2011-12-12 18:27:46 PST
Following changes to GfxInfo in 706702, xpcshell tests and their associated spoofing API are now out of date. These must be updated to support new string-based (non-hex) vendor and device ID's. Additionally, the semantics of each platform are now different, so we have to spoof things in different ways depending on the platform that they're running on.
Comment 1 Doug Sherk (:drs) (inactive) 2011-12-13 00:41:45 PST
Created attachment 581196 [details] [diff] [review]
Patch v1.0, update XPCShell tests for GfxInfo blocklisting.

Also snuck in some fixes for Linux adapter device/vendor getting and spoofing.
Comment 2 Doug Sherk (:drs) (inactive) 2011-12-13 00:42:19 PST
Try push: https://tbpl.mozilla.org/?tree=Try&rev=6636376b8c90
Comment 3 Joe Drew (not getting mail) 2011-12-13 13:24:43 PST
Comment on attachment 581196 [details] [diff] [review]
Patch v1.0, update XPCShell tests for GfxInfo blocklisting.

Review of attachment 581196 [details] [diff] [review]:
-----------------------------------------------------------------

My only real concern is about the DirectX checks you added in GfxInfoX11. Do you really need them?

::: toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverNew.js
@@ +52,5 @@
> +    case "Linux":
> +      do_test_finished();
> +      return;
> +    case "Darwin":
> +      do_test_finished();

Add comments here (and in all js files) - "// We don't support driver versions on..."

::: widget/public/nsIGfxInfoDebug.idl
@@ +38,5 @@
>  #include "nsISupports.idl"
>  
>  /* NOTE: this interface is only implemented in debug builds */
>  
>  [scriptable, uuid(0c19c88a-9ef1-4bb4-b0a2-86ab768e8bd6)]

Should change the UUID here, not that it matters

::: widget/src/xpwidgets/GfxInfoX11.cpp
@@ +282,5 @@
>  #endif
>  
>    // Don't evaluate any special cases if we're checking the downloaded blocklist.
> +  // Never check DirectX because it's never relevant to Linux, and we use it in
> +  // the XPCShell tests.

Hm, I'm not too fussy about adding these checks. Shouldn't the feature be silently ignored?
Comment 4 Doug Sherk (:drs) (inactive) 2011-12-13 20:37:40 PST
Created attachment 581528 [details] [diff] [review]
Patch v1.1, update XPCShell tests for GfxInfo blocklisting.

Addressed code review comments, r+ carried (see bug 710432 for more code review).
Comment 5 Doug Sherk (:drs) (inactive) 2011-12-14 01:09:23 PST
Try push: https://tbpl.mozilla.org/?tree=Try&rev=864451bfe1b9
Comment 6 Doug Sherk (:drs) (inactive) 2011-12-14 23:56:08 PST
https://tbpl.mozilla.org/?rev=fe937bac6e75
Comment 7 Doug Sherk (:drs) (inactive) 2011-12-15 01:26:54 PST
https://hg.mozilla.org/mozilla-central/rev/fe937bac6e75
Comment 8 Benoit Jacob [:bjacob] (mostly away) 2012-03-08 15:10:40 PST
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/ec62feca7f74
See Bug 711656 for explanation.

Note You need to log in before you can comment on or make changes to this bug.