Last Comment Bug 710432 - Linux GfxInfo does no checks on feature
: Linux GfxInfo does no checks on feature
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Doug Sherk (:drs) (inactive)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 706702
  Show dependency treegraph
 
Reported: 2011-12-13 15:09 PST by Doug Sherk (:drs) (inactive)
Modified: 2012-03-08 15:11 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1.0, fix Linux GfxInfo to do feature checks (6.34 KB, patch)
2011-12-13 20:36 PST, Doug Sherk (:drs) (inactive)
joe: review+
Details | Diff | Splinter Review

Description Doug Sherk (:drs) (inactive) 2011-12-13 15:09:51 PST
Linux's GfxInfo implementation blocks all features if the driver is blacklisted, even if the features have nothing to do with Linux, like D3D. Also, there's no way to get the adapter vendor or adapter device ID from this class.
Comment 1 Doug Sherk (:drs) (inactive) 2011-12-13 20:36:32 PST
Created attachment 581527 [details] [diff] [review]
Patch v1.0, fix Linux GfxInfo to do feature checks

As per code review comments from bug 710103. This patch goes before the one in bug 710103.
Comment 2 Doug Sherk (:drs) (inactive) 2011-12-14 01:09:17 PST
Try push: https://tbpl.mozilla.org/?tree=Try&rev=864451bfe1b9
Comment 3 Doug Sherk (:drs) (inactive) 2011-12-14 23:56:27 PST
https://tbpl.mozilla.org/?rev=fe937bac6e75
Comment 4 Doug Sherk (:drs) (inactive) 2011-12-15 01:24:51 PST
https://hg.mozilla.org/mozilla-central/rev/dd2e6ce53715
Comment 5 Benoit Jacob [:bjacob] (mostly away) 2012-03-08 15:11:34 PST
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/d03bd265ed6c
See Bug 711656 for explanation.

Note You need to log in before you can comment on or make changes to this bug.