Closed
Bug 710239
Opened 12 years ago
Closed 12 years ago
Minimonth and Timepicker mousewheel support is broken [Error: NSUIEvent is not defined]
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: ssitter, Assigned: ssitter)
References
Details
Attachments
(1 file)
3.80 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Lightning 1.1b1 + Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111130 Thunderbird/9.0 Steps to reproduce: 1) Switch to calendar or task tab 2) Move mouse over the minimonth in Calendar pane or Today pane 3) Use scrollwheel on mouse Actual Results: Nothing happens. Console shows: Error: NSUIEvent is not defined Source File: chrome://calendar/content/widgets/minimonth.xml Line: 1170 Expected Results: Minimonth display switches to next or previous month.
Assignee | ||
Comment 1•12 years ago
|
||
Same error happens in the Timepicker control: http://mxr.mozilla.org/comm-central/search?string=NSUIEvent&find=/calendar/
Summary: Minimonth mousewheel support is broken [Error: NSUIEvent is not defined] → Minimonth and Timepicker mousewheel support is broken [Error: NSUIEvent is not defined]
Assignee | ||
Comment 2•12 years ago
|
||
Looking at the check-in for Bug 672054 (http://hg.mozilla.org/mozilla-central/rev/ce4f04d1c8e7) we might use |UIEvent| instead of |NSUIEvent|
Blocks: 672054
Comment 3•12 years ago
|
||
That would be correct.
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Comment on attachment 581395 [details] [diff] [review] replace NSUIEvent with UIEvent I think since the event implements UIEvent, you could also do event.SCROLL_PAGE_DOWN. That might be more future proof. I'm fine with either though, r=philipp If you push this before Mark does the beta 2 builds (Tomorrow or Thursday), you can backport all the way down to comm-beta.
Attachment #581395 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Pushed to https://hg.mozilla.org/comm-central/rev/136c73144a58 I used UIEvent because it matches what is used in /mozilla/toolkit/content/widgets/tree.xml and /mozilla/toolkit/content/widgets/listbox.xml.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Assignee | ||
Comment 7•12 years ago
|
||
Ported back to https://hg.mozilla.org/releases/comm-aurora/rev/cc60f45fcbd1 Ported back to https://hg.mozilla.org/releases/comm-beta/rev/270b3a4ee6e4
Target Milestone: 1.3 → 1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•