Remove nsIDOMNSEvent

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({addon-compat, dev-doc-needed})

Trunk
mozilla17
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #672054 +++

Comment 1

5 years ago
This would fix also those few cases when
DOMClassInfo has 
DOM_CLASSINFO_MAP_ENTRY(nsIDOMEvent) but should have 
DOM_CLASSINFO_EVENT_MAP_ENTRIES

Ms2ger, are you working on this? If not, assign to me.
(Assignee)

Comment 2

5 years ago
Created attachment 643780 [details] [diff] [review]
Patch v1

How does this look to you?
Attachment #643780 - Flags: review?(bugs)

Comment 3

5 years ago
Comment on attachment 643780 [details] [diff] [review]
Patch v1

Hrm, perhaps we should keep nsIDOMNSEvent, but make it empty and extend nsIDOMEvent.

Comment 4

5 years ago
Comment on attachment 643780 [details] [diff] [review]
Patch v1


Please add a test which checks that all the properties found in window.NSEvent are found also in window.Event and have the
same value.
Attachment #643780 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0bb1a5882d49
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Comment 6

5 years ago
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/df072441c8bb
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/df072441c8bb
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.