Last Comment Bug 716822 - Remove nsIDOMNSEvent
: Remove nsIDOMNSEvent
Status: RESOLVED FIXED
: addon-compat, dev-doc-needed
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 672054 710239
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-10 00:28 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-08-04 18:40 PDT (History)
5 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (89.95 KB, patch)
2012-07-19 03:08 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-01-10 00:28:23 PST
+++ This bug was initially created as a clone of Bug #672054 +++
Comment 1 Olli Pettay [:smaug] 2012-07-19 01:47:17 PDT
This would fix also those few cases when
DOMClassInfo has 
DOM_CLASSINFO_MAP_ENTRY(nsIDOMEvent) but should have 
DOM_CLASSINFO_EVENT_MAP_ENTRIES

Ms2ger, are you working on this? If not, assign to me.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-07-19 03:08:40 PDT
Created attachment 643780 [details] [diff] [review]
Patch v1

How does this look to you?
Comment 3 Olli Pettay [:smaug] 2012-07-19 03:18:32 PDT
Comment on attachment 643780 [details] [diff] [review]
Patch v1

Hrm, perhaps we should keep nsIDOMNSEvent, but make it empty and extend nsIDOMEvent.
Comment 4 Olli Pettay [:smaug] 2012-07-23 13:43:23 PDT
Comment on attachment 643780 [details] [diff] [review]
Patch v1


Please add a test which checks that all the properties found in window.NSEvent are found also in window.Event and have the
same value.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2012-08-04 01:57:13 PDT
https://hg.mozilla.org/mozilla-central/rev/0bb1a5882d49
Comment 6 Ed Morley [:emorley] 2012-08-04 11:28:50 PDT
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-04 14:49:38 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/df072441c8bb
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-04 18:40:49 PDT
https://hg.mozilla.org/mozilla-central/rev/df072441c8bb

Note You need to log in before you can comment on or make changes to this bug.