Closed
Bug 716822
Opened 14 years ago
Closed 14 years ago
Remove nsIDOMNSEvent
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(1 file)
|
89.95 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #672054 +++
Comment 1•14 years ago
|
||
This would fix also those few cases when
DOMClassInfo has
DOM_CLASSINFO_MAP_ENTRY(nsIDOMEvent) but should have
DOM_CLASSINFO_EVENT_MAP_ENTRIES
Ms2ger, are you working on this? If not, assign to me.
| Assignee | ||
Comment 2•14 years ago
|
||
How does this look to you?
Attachment #643780 -
Flags: review?(bugs)
Comment 3•14 years ago
|
||
Comment on attachment 643780 [details] [diff] [review]
Patch v1
Hrm, perhaps we should keep nsIDOMNSEvent, but make it empty and extend nsIDOMEvent.
Comment 4•14 years ago
|
||
Comment on attachment 643780 [details] [diff] [review]
Patch v1
Please add a test which checks that all the properties found in window.NSEvent are found also in window.Event and have the
same value.
Attachment #643780 -
Flags: review?(bugs) → review+
| Assignee | ||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 6•14 years ago
|
||
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•14 years ago
|
||
Flags: in-testsuite+
Comment 8•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•