Closed Bug 710345 Opened 8 years ago Closed 8 years ago
Upgrade pywebsocket to v606 (support final WS spec)
v606 supports protocol v17, and Sec-WebSocket-Version: 13, which we need. Splitting into two patches: google's changes, and tweaks I made to get it to work for us.
So this sits on top of the pywebsocket patch (not yet landed) for bug 689006. I've split this out from changes I made as I think it needs minimal review, given that it's already reviewed and in production @ google.
Assignee: nobody → jduell.mcbugs
Status: NEW → ASSIGNED
Attachment #581378 - Flags: review?(mcmanus)
test_websocket.html test-15 needed to be disabled: see comments. It's not a bug in our code, just that pywebsocket doesn't seem to allow us to emulate the server closing the TCP socket w/o sending a WS CLOSE any more. (if you think we need that test to work, let's open a separate bug for it--don't want to hold back progress for a minor test coverage issue). test-16 fails if run standalone--fixed. change runtests.py to use --allow-handlers-outside-root-dir so we don't have to patch pywebsocket code for that any more.
Attachment #581383 - Flags: review?(mcmanus)
Attachment #581378 - Flags: review?(mcmanus) → review+
Comment on attachment 581383 [details] [diff] [review] part2: Mozilla-specific changes file a separate low priority bug about creating test coverage for the disabled test-15. r=mcmanus
Attachment #581383 - Flags: review?(mcmanus) → review+
Thanks. Filed bug 710954 for test-15.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.