Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Upgrade pywebsocket to v606 (support final WS spec)

RESOLVED FIXED in mozilla11

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jduell, Assigned: jduell)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

v606 supports protocol v17, and Sec-WebSocket-Version: 13, which we need.

Splitting into two patches: google's changes, and tweaks I made to get it to work for us.
(Assignee)

Comment 1

6 years ago
Created attachment 581378 [details] [diff] [review]
part1: Google pywebsocket v553->606 changes

So this sits on top of the pywebsocket patch (not yet landed) for bug 689006.

I've split this out from changes I made as I think it needs minimal review, given that it's already reviewed and in production @ google.
Assignee: nobody → jduell.mcbugs
Status: NEW → ASSIGNED
Attachment #581378 - Flags: review?(mcmanus)
(Assignee)

Comment 2

6 years ago
Created attachment 581383 [details] [diff] [review]
part2: Mozilla-specific changes

test_websocket.html test-15 needed to be disabled: see comments. It's not a bug in our code, just that pywebsocket doesn't seem to allow us to emulate the server closing the TCP socket w/o sending a WS CLOSE any more. (if you think we need that test to work, let's open a separate bug for it--don't want to hold back progress for a minor test coverage issue).

test-16 fails if run standalone--fixed.

change runtests.py to use --allow-handlers-outside-root-dir so we don't have to patch pywebsocket code for that any more.
Attachment #581383 - Flags: review?(mcmanus)
Attachment #581378 - Flags: review?(mcmanus) → review+
Comment on attachment 581383 [details] [diff] [review]
part2: Mozilla-specific changes

file a separate low priority bug about creating test coverage for the disabled test-15.

r=mcmanus
Attachment #581383 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 4

6 years ago
Thanks.

Filed bug 710954 for test-15.
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/225f854f8ff1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Comment 6

6 years ago
Also

https://hg.mozilla.org/mozilla-central/rev/ccb71819f0c2
You need to log in before you can comment on or make changes to this bug.