710350 - Don't hard-code 'firefox' and 'fennec' in misc.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

productName 'firefox' and 'fennec' are hard-coded here in misc.py:

 http://hg.mozilla.org/build/buildbotcustom/file/7baaa68ea9b9/misc.py#l375

We need to make this config-driven so that Thunderbird can use the same automation.

Comment 1

[[e-mail] (:bhearsum)]

It looks like this was originally done in bug 511282, and tweaked a bit in bug 605176. We _do_ have product_name in the configs (http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla/config.py#l82), but it's in GLOBAL_VARS, which means it can't be overridden per platform. John, can you take a whack at moving it from there into PLATFORM_VARS? Roughly, that should involve:
* Removing it from GLOBAL_VARS (config.py)
* Adding it to each of the platforms in PLATFORM_VARS (config.py)
* Roughly, s/config['productName']/pf['productName']/ (misc.py)

app_name and brand_name are also labeled as "not valid for mobile builds", so could you move those two, as well?

Comment 2

[John Hopkins (:jhopkins)]

Attachment: buildbot-configs patch

Comment 3

[John Hopkins (:jhopkins)]

Attachment: buildbotcustom patch

Comment 4

[John Hopkins (:jhopkins)]

Attachment: buildbot-configs patch

refreshed

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 582914 [details] [diff] [review]
buildbotcustom patch

Looks good to me!

Comment 6

[John Hopkins (:jhopkins)]

Comment on attachment 583172 [details] [diff] [review]
buildbot-configs patch

Landed in https://hg.mozilla.org/build/buildbot-configs/rev/9e1f7c4af67f

Comment 7

[John Hopkins (:jhopkins)]

Comment on attachment 582914 [details] [diff] [review]
buildbotcustom patch

Landed in https://hg.mozilla.org/build/buildbotcustom/rev/41d33904e045

Comment 8

[Armen [:armenzg]]

The patches that landed on "default" are now on production and the masters have been reconfigured.