The default bug view has changed. See this FAQ.

exclude about: pages from top sites on about:home

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
5 years ago
8 months ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, firefox12 verified, fennec11+)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Duplicate of this bug: 709550
(Assignee)

Updated

5 years ago
Priority: -- → P1
Duplicate of this bug: 712889
Ok this bug is a dup of the one i filed but what is happening with it?

-is it not consider as a bug? and we live with it
-is it a bug, who is going to work on it
Assignee: nobody → lucasr.at.mozilla

Updated

5 years ago
Duplicate of this bug: 715249
Created attachment 585974 [details] [diff] [review]
patch
Assignee: lucasr.at.mozilla → blassey.bugs
Attachment #585974 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 585974 [details] [diff] [review]
patch

Review of attachment 585974 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but shouldn't we simply avoid recording visits to about: pages in history DB altogether? For instance, I think we shouldn't show about: pages in the history tab either. Also, we don't want stock browser to have list about: pages as they're Fennec-specific. I'm giving a r- until a good reason is given to keep about: records on DB.
Attachment #585974 - Flags: review?(lucasr.at.mozilla) → review-
Desktop Firefox and XUL Fennec do not record about:* to history. However, you can bookmark an about:* page and it then will appear in the awesomebar results.

We could do the same thing in Native Fennec, but a bookmarked about:* page would likely show up in the "Top Sites" list, unless we filter. Even about:home
Comment on attachment 585974 [details] [diff] [review]
patch

(In reply to Lucas Rocha (:lucasr) from comment #6)
> Comment on attachment 585974 [details] [diff] [review]
> patch
> 
> Review of attachment 585974 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good but shouldn't we simply avoid recording visits to about: pages in
> history DB altogether? For instance, I think we shouldn't show about: pages
> in the history tab either. Also, we don't want stock browser to have list
> about: pages as they're Fennec-specific. I'm giving a r- until a good reason
> is given to keep about: records on DB.

1) That doesn't fix the issue for anyone that's used fennec up to now and has about:pages in their history
2) about: pages should at least show up in the Awesomebar if their bookmarked
3) given that we only show 3 or 4 top sites, I think we should exclude them from the top sites section regardess of whether they're in history or not

So, I suggest we need this whether we stop putting about pages in history or not
Attachment #585974 - Flags: review- → review?(lucasr.at.mozilla)
Comment on attachment 585974 [details] [diff] [review]
patch

Review of attachment 585974 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, please make sure there's a bug report about not storing about: pages in history.
Attachment #585974 - Flags: review?(lucasr.at.mozilla) → review+

Comment 10

5 years ago
This hides all about pages, right? Changing summary accordingly.
Summary: exclude about:home from top sites on about:home → exclude about: pages from top sites on about:home
About:home is really the only about: page that should be excluded on about:home. I think about: pages should be in history, too.
https://hg.mozilla.org/mozilla-central/rev/4f11bea71a4a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120106 Firefox/12.0a1 Fennec/12.0a1
20120106043323
http://hg.mozilla.org/mozilla-central/rev/af6501ede378

Aurora nom?
Status: RESOLVED → VERIFIED
status-firefox11: --- → affected
status-firefox12: --- → verified
(Assignee)

Updated

5 years ago
tracking-fennec: --- → 11+

Updated

5 years ago
Depends on: 716089
Blocks: 716623
Comment on attachment 585974 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
"top sites" section about:home can be completely occupied by about: pages, such as about:home
Testing completed (on m-c, etc.): 
on m-c
Risk to taking this patch (and alternatives if risky):
pretty risk-free
Attachment #585974 - Flags: approval-mozilla-aurora?
Comment on attachment 585974 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #585974 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/984285420b33
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.