716089 - Crash on startup: malformed query in local DB history query

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Richard Newman [:rnewman]]

Throwing this at you, lucasr. Please redirect if someone else can fix it sooner!

I have a patch applied that switches to using local DB. See try build:

https://tbpl.mozilla.org/?tree=Try&rev=9e860976a737

Log here:

http://rnewman.pastebin.mozilla.org/1437403

 FATAL EXCEPTION: GeckoLooper Thread
 android.database.sqlite.SQLiteException: near "(": syntax error: , while compiling: SELECT _id, url, title, favicon, thumbnail FROM history_with_images WHERE ((deleted = 0) AND ((url NOT LIKE ? )(url LIKE ? OR title LIKE ?))) ORDER BY visits * MAX(1, (date - 1325889145182) / 86400000 + 120) DESC LIMIT 4
     at android.database.sqlite.SQLiteCompiledSql.native_compile(Native Method)
     at android.database.sqlite.SQLiteCompiledSql.<init>(SQLiteCompiledSql.java:64)
     at android.database.sqlite.SQLiteProgram.compileSql(SQLiteProgram.java:143)
     at android.database.sqlite.SQLiteProgram.compileAndbindAllArgs(SQLiteProgram.java:361)
     at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:127)
     at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:94)
     at android.database.sqlite.SQLiteQuery.<init>(SQLiteQuery.java:51)
     at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:47)
     at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1573)
     at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:354)
     at org.mozilla.fennec_rnewman.db.BrowserProvider.query(BrowserProvider.java:939)
     at android.content.ContentProvider$Transport.query(ContentProvider.java:178)
     at android.content.ContentResolver.query(ContentResolver.java:310)
     at org.mozilla.gecko.db.LocalBrowserDB.filter(LocalBrowserDB.java:85)
     at org.mozilla.gecko.db.BrowserDB.filter(BrowserDB.java:92)
     at org.mozilla.gecko.AboutHomeContent$4.run(AboutHomeContent.java:171)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fix query syntax for filtering URLs on local DB

Regression caused by patch in bug 710392.

Comment 2

[Richard Newman [:rnewman]]

Inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fb4756a6cbc

Comment 3

[Richard Newman [:rnewman]]

Ugh, cleared tracking fields. Fail.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9fb4756a6cbc

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 586946 [details] [diff] [review]
Fix query syntax for filtering URLs on local DB

Fix a serious crash on startup when using local DB (which is enabled now).

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 586946 [details] [diff] [review]
Fix query syntax for filtering URLs on local DB

[Triage Comment]
Mobile only - approving for Aurora.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed to mozilla-aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/8a36f0202bd7