Closed Bug 710750 Opened 11 years ago Closed 11 years ago

ESC key should exit Tilt (page inspector 3D)

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11- verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 - verified

People

(Reporter: dangoor, Assigned: vporof)

References

Details

(Whiteboard: [tilt][fixed-in-fx-team][qa+][qa!:11])

Attachments

(2 files)

v1
4.49 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review
v2
4.46 KB, patch
rcampbell
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Right now, pressing <esc> does nothing when you are in 3D mode of the page inspector. It would be nice if <esc> would exit 3D mode.
Whiteboard: [tilt]
Attached patch v1 — — Splinter Review 

        Attachment #581933 -
        Flags: review?(rcampbell)

    
  
Blocks: 711341

    
    

    
  
Comment on attachment 581933 [details] [diff] [review]
v1

looks good!

        Attachment #581933 -
        Flags: review?(rcampbell) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  
Because bug 700199 recently changed how EventUtils.sendKey works.

        Attachment #582864 -
        Flags: review?

    
  

        Attachment #582864 -
        Flags: review? → review?(rcampbell)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 582864 [details] [diff] [review]
v2

like

        Attachment #582864 -
        Flags: review?(rcampbell) → review+

    
    

    
  
Comment on attachment 582864 [details] [diff] [review]
v2

would like to get this into aurora. Adds an ESC keyboard shortcut to exit tilt and return to the regular view in the Inspector. minimal impact. maximal enjoyment.

        Attachment #582864 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c2cb5d6b8cb9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

    
    

    
  
Comment on attachment 582864 [details] [diff] [review]
v2

[triage comment]
Approved for aurora. "minimal impact. maximal enjoyment". Simple fix to a new feature.

        Attachment #582864 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
QA Verified on Firefox 11 & Firefox 12
Status: RESOLVED → VERIFIED

    
  
Whiteboard: [tilt][fixed-in-fx-team] → [tilt][fixed-in-fx-team][qa+]

    
    

    
  
Verified using Firefox 11 beta 4 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6 - pressing Esc key exits Tilt.

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0

          status-firefox11:
          fixed → verified
Whiteboard: [tilt][fixed-in-fx-team][qa+] → [tilt][fixed-in-fx-team][qa+][qa!:11]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.