ESC key should exit Tilt (page inspector 3D)

VERIFIED FIXED in Firefox 11

Status

()

Firefox
Developer Tools
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Kevin Dangoor, Assigned: vporof)

Tracking

unspecified
Firefox 12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox11- verified)

Details

(Whiteboard: [tilt][fixed-in-fx-team][qa+][qa!:11])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Right now, pressing <esc> does nothing when you are in 3D mode of the page inspector. It would be nice if <esc> would exit 3D mode.
(Assignee)

Updated

6 years ago
Whiteboard: [tilt]
(Assignee)

Comment 1

6 years ago
Created attachment 581933 [details] [diff] [review]
v1
Attachment #581933 - Flags: review?(rcampbell)
(Assignee)

Updated

6 years ago
Blocks: 711341
Comment on attachment 581933 [details] [diff] [review]
v1

looks good!
Attachment #581933 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 582864 [details] [diff] [review]
v2

Because bug 700199 recently changed how EventUtils.sendKey works.
Attachment #582864 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #582864 - Flags: review? → review?(rcampbell)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Comment on attachment 582864 [details] [diff] [review]
v2

like
Attachment #582864 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/integration/fx-team/rev/c2cb5d6b8cb9
tracking-firefox11: --- → ?
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
Comment on attachment 582864 [details] [diff] [review]
v2

would like to get this into aurora. Adds an ESC keyboard shortcut to exit tilt and return to the regular view in the Inspector. minimal impact. maximal enjoyment.
Attachment #582864 - Flags: approval-mozilla-aurora?

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c2cb5d6b8cb9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

Comment 8

6 years ago
Comment on attachment 582864 [details] [diff] [review]
v2

[triage comment]
Approved for aurora. "minimal impact. maximal enjoyment". Simple fix to a new feature.
Attachment #582864 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b8cb000c284
status-firefox11: --- → fixed

Updated

5 years ago
tracking-firefox11: ? → -
QA Verified on Firefox 11 & Firefox 12
Status: RESOLVED → VERIFIED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt][fixed-in-fx-team][qa+]
Verified using Firefox 11 beta 4 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6 - pressing Esc key exits Tilt.

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
status-firefox11: fixed → verified
Whiteboard: [tilt][fixed-in-fx-team][qa+] → [tilt][fixed-in-fx-team][qa+][qa!:11]
You need to log in before you can comment on or make changes to this bug.