Tilt should give focus back to Highlighter when closed

VERIFIED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Inspector
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(firefox11+ verified)

Details

(Whiteboard: [tilt][fixed-in-fx-team][qa+][qa!:11])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Whiteboard: [tilt]
(Assignee)

Updated

6 years ago
Assignee: nobody → vporof
(Assignee)

Comment 1

6 years ago
Created attachment 582194 [details] [diff] [review]
v1
Attachment #582194 - Flags: review?(rcampbell)
(Assignee)

Comment 2

6 years ago
Depends on bug 710750 because of an "instance" param added to onTiltOpen in head.js for testing to work properly.
Depends on: 710750
Attachment #582194 - Flags: review?(rcampbell) → review+
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/9aa0f5842d75
tracking-firefox11: --- → ?
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
Comment on attachment 582194 [details] [diff] [review]
v1

This restores focus on the content window when tilt is closed. Leaves you where you were before you made everything go all tilty! Would be nice in aurora...
Attachment #582194 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9aa0f5842d75
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

Comment 6

6 years ago
Comment on attachment 582194 [details] [diff] [review]
v1

[triage comment]
Approved for aurora. While this probably wouldn't meet our criteria at the end of a cycle ("nice to have", feature works fine without, etc). We are early in the cycle and the risk looks low to take this for what will likely be a banner feature.
Attachment #582194 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/f089c471e778
status-firefox11: --- → fixed

Updated

6 years ago
tracking-firefox11: ? → +
Verified on Firefox 11 & Firefox 12
Status: RESOLVED → VERIFIED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt][fixed-in-fx-team][qa+]

Comment 9

5 years ago
Verified using Firefox 11 Beta 4 on Win XP, Mac OS X 10.6 and Ubuntu 11.10 - focus is on the Highlighter after Tilt is closed.

Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
status-firefox11: fixed → verified
Whiteboard: [tilt][fixed-in-fx-team][qa+] → [tilt][fixed-in-fx-team][qa+][qa!:11]
You need to log in before you can comment on or make changes to this bug.