Make inactive tabs opaque under Aero

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Theme
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: squib, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 11.0
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needs tabsontop)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Base on this screenshot <http://dl.dropbox.com/u/2301433/Screenshots/TabsOnTop/4-Gloda.png>, inactive tabs are translucent. We should follow Firefox's lead in this case and make them opaque, so no one can complain about there being too much glass. :)
(Assignee)

Comment 1

6 years ago
All rules equal to Firefox are also in TB's css. The problem is the order the rules are applied.

I take the Bug.
Assignee: nobody → richard.marti
(Assignee)

Comment 2

6 years ago
Created attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

Fixed the order how the rules are applied and use the same bottom gradient as from the hover rule.
Attachment #581784 - Flags: review?(squibblyflabbetydoo)
(Reporter)

Comment 3

6 years ago
Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

Unfortunately, I don't have time to test this, so clearing the review out. Maybe mconley or andreasn could take a look?
Attachment #581784 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Updated

6 years ago
Attachment #581784 - Flags: review?(mconley)
Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

This looks good to me - thanks Paenglab!
Attachment #581784 - Flags: review?(mconley) → review+
Created attachment 581964 [details]
A screenshot of the above patch

Blake:

The patch looks good to me, and I agree that it looks better.  Look alright to you?

-Mike
Attachment #581964 - Flags: ui-review?(bwinton)
Attachment #581964 - Flags: ui-review?(bwinton)
Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

(Just setting ui-r=me on the patch itself...)

Yeah, I think this makes it easier to read.
Attachment #581784 - Flags: ui-review+
Keywords: checkin-needed
Whiteboard: needs tabsontop
Move 644169 from blocking to depends, since 644169 works without this patch, but this patch won't work without 644169. Hope that is all right.
No longer blocks: 644169
Depends on: 644169
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/c48dcb162b4c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Target Milestone: --- → Thunderbird 11.0
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.