710867 - Make inactive tabs opaque under Aero

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Porter (:squib)]

Base on this screenshot <http://dl.dropbox.com/u/2301433/Screenshots/TabsOnTop/4-Gloda.png>, inactive tabs are translucent. We should follow Firefox's lead in this case and make them opaque, so no one can complain about there being too much glass. :)

Comment 1

[Richard Marti (:Paenglab)]

All rules equal to Firefox are also in TB's css. The problem is the order the rules are applied.

I take the Bug.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Make the inactive tabs opaque

Fixed the order how the rules are applied and use the same bottom gradient as from the hover rule.

Comment 3

[Jim Porter (:squib)]

Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

Unfortunately, I don't have time to test this, so clearing the review out. Maybe mconley or andreasn could take a look?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

This looks good to me - thanks Paenglab!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: A screenshot of the above patch

Blake:

The patch looks good to me, and I agree that it looks better.  Look alright to you?

-Mike

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 581784 [details] [diff] [review]
Make the inactive tabs opaque

(Just setting ui-r=me on the patch itself...)

Yeah, I think this makes it easier to read.

Comment 7

[Andreas Nilsson (:andreasn)]

Move 644169 from blocking to depends, since 644169 works without this patch, but this patch won't work without 644169. Hope that is all right.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/c48dcb162b4c