710980 - Array overrun in intl/chardet/tests/DetectCharset.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Mike Hommey [:glandium]]

The problematic code is the following:
class nsBaseStatis : public nsStatis {
public:
  ...
  PRUint32 mLWordLen[10]; 
  ...
  nsBaseStatis::nsBaseStatis(...)
  {
    ...
    for(PRUint32 i = 0; i < 20; i++)
       mLWordLen[i] = 0;
    ...
  }
  ...
};

Now, there are a few interesting things to note about this:
- This code is in a testcase
- The nsBaseStatis class is never used
- The test is only built on Windows
- AFAICS, the test is actually never run

Considering the above, I'm tempted to say the solution is rm -rf intl/chardet/tests.

Comment 2

[Simon Montagu :smontagu]

(In reply to Mike Hommey [:glandium] from comment #0)
> Considering the above, I'm tempted to say the solution is rm -rf
> intl/chardet/tests.

I agree with this, especially since intl/chardet has been almost entirely superseded by extensions/universalchardet.

Comment 3

[Simon Montagu :smontagu]

Attachment: remove it

Comment 4

[Mike Hommey [:glandium]]

You need to modify intl/chardet/Makefile.in as well.

Comment 5

[Simon Montagu :smontagu]

Attachment: Patch v.2

Comment 6

[Masatoshi Kimura [:emk]]

> I agree with this, especially since intl/chardet has been almost entirely
> superseded by extensions/universalchardet.
Is it possible to remove intl/chardet entirely?
It will steer Win PGO builds away from the 3GB virtual address space limit a bit.

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 582193 [details] [diff] [review]
Patch v.2

r=me anyway.

Comment 8

[Simon Montagu :smontagu]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> Is it possible to remove intl/chardet entirely?

Filed bug 711790

Comment 9

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28cd0159472e

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/28cd0159472e