Closed Bug 710980 Opened 10 years ago Closed 10 years ago

Array overrun in intl/chardet/tests/DetectCharset.cpp

Categories

(Core :: Internationalization, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: glandium, Assigned: smontagu)

References

Details

(Whiteboard: [pvs-studio])

Attachments

(1 file, 1 obsolete file)

The problematic code is the following:
class nsBaseStatis : public nsStatis {
public:
  ...
  PRUint32 mLWordLen[10]; 
  ...
  nsBaseStatis::nsBaseStatis(...)
  {
    ...
    for(PRUint32 i = 0; i < 20; i++)
       mLWordLen[i] = 0;
    ...
  }
  ...
};

Now, there are a few interesting things to note about this:
- This code is in a testcase
- The nsBaseStatis class is never used
- The test is only built on Windows
- AFAICS, the test is actually never run

Considering the above, I'm tempted to say the solution is rm -rf intl/chardet/tests.
Duplicate of this bug: 710982
Whiteboard: [pvs-studio]
(In reply to Mike Hommey [:glandium] from comment #0)
> Considering the above, I'm tempted to say the solution is rm -rf
> intl/chardet/tests.

I agree with this, especially since intl/chardet has been almost entirely superseded by extensions/universalchardet.
Attached patch remove it (obsolete) — Splinter Review
Attachment #582188 - Flags: review?(VYV03354)
You need to modify intl/chardet/Makefile.in as well.
Attached patch Patch v.2Splinter Review
Attachment #582188 - Attachment is obsolete: true
Attachment #582188 - Flags: review?(VYV03354)
Attachment #582193 - Flags: review?(VYV03354)
> I agree with this, especially since intl/chardet has been almost entirely
> superseded by extensions/universalchardet.
Is it possible to remove intl/chardet entirely?
It will steer Win PGO builds away from the 3GB virtual address space limit a bit.
Comment on attachment 582193 [details] [diff] [review]
Patch v.2

r=me anyway.
Attachment #582193 - Flags: review?(VYV03354) → review+
(In reply to Masatoshi Kimura [:emk] from comment #6)
> Is it possible to remove intl/chardet entirely?

Filed bug 711790
https://hg.mozilla.org/integration/mozilla-inbound/rev/28cd0159472e
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/28cd0159472e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.