Fix velocity calculation

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P3
normal
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: lmandel, Assigned: wesj)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec+)

Details

(Whiteboard: [mtd][inbound])

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 581967 [details]
catlog while being unable to scroll

Build:20111214
Device: Samsung Galaxy S II

Occasionally when I open the browser to a page I cannot scroll at all. Firefox does not respond to any panning/scrolling touch events. Note that at this time I can still click buttons, links, and the awesome bar. I can also zoom. Restarting the browser allows me to pan/scroll again.

Unfortunately I have not been able to determine a reliable path to reproduce the issue. I was able to catch a catlog with some interesting messages that I hope will shed some light on the source of this issue.

12-15 10:36:30.900: I/GeckoSoftwareLayerClient(10290): Adjusting viewport
12-15 10:36:31.130: I/InputReader(2715): dispatchTouch::touch event's action is 0, pending(waiting finished signal)=0
12-15 10:36:31.140: I/InputDispatcher(2715): Delivering touch to current input target: action: 0, channel '40767260 org.mozilla.fennec/org.mozilla.fennec.App (server)'
12-15 10:36:31.145: E/lights(2715): write_int: path /sys/devices/virtual/misc/melfas_touchkey/brightness, value 1
12-15 10:36:31.145: I/PowerManagerService(2715): Ulight 3->7|0
12-15 10:36:31.145: D/PowerManagerService(2715): setLightBrightness : mButtonLight : 69
12-15 10:36:31.175: E/GeckoPanZoomController(10290): Received impossible touch move while in NOTHING
12-15 10:36:31.185: E/GeckoPanZoomController(10290): Received impossible touch move while in NOTHING
12-15 10:36:31.230: E/GeckoPanZoomController(10290): Received impossible touch move while in NOTHING
...
Summary: Scrolling occasionally doesn't work → Panning/scrolling occasionally doesn't work
recent regression? dupe of bug 710694?
The video in bug 710694 shows different behaviour than what I'm seeing here. There is no jumping or random resizing as shown. For me, the page loads fine but is stuck from a pan/scroll position. I can zoom in or out as expected but still can't move the page up/down/left/right.

Updated

6 years ago
Assignee: nobody → pwalton
Priority: -- → P2
(Assignee)

Comment 3

6 years ago
Created attachment 583032 [details] [diff] [review]
Patch

This fixes some issues with the fling controller. I'm also sometimes seeing finishAnimation called over and over and over. Apparently we're killing the timertask but not cancelling? Still digging on that bit.

Looking into this because I'm running into issues while working on the touchevents stuff, and want to see if there faults with those patches or something else.
tracking-fennec: --- → 11+

Comment 4

6 years ago
is your patch needed?  has this problem been addressed already.
Assignee: pwalton → wjohnston
(Assignee)

Comment 5

6 years ago
Created attachment 591226 [details] [diff] [review]
Patch

Not fixed yet.
Attachment #583032 - Attachment is obsolete: true
Attachment #591226 - Flags: review?(pwalton)
(In reply to Wesley Johnston (:wesj) from comment #3)
> This fixes some issues with the fling controller. I'm also sometimes seeing
> finishAnimation called over and over and over. Apparently we're killing the
> timertask but not cancelling? Still digging on that bit.

If you figure out anything to do with this, let me know. I have bug 713011 which is tracking this issue.
tracking-fennec: 11+ → +
Priority: P2 → P3
Summary: Panning/scrolling occasionally doesn't work → Fix velocity calcualtion
Changed bug into something appropriate for the patch. Bug 713011 will handle the panning issue
Summary: Fix velocity calcualtion → Fix velocity calculation
Comment on attachment 591226 [details] [diff] [review]
Patch

Review of attachment 591226 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #591226 - Flags: review?(pwalton) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f8282085e225
Whiteboard: [mtd] → [mtd][inbound]
(Assignee)

Comment 10

6 years ago
Comment on attachment 591226 [details] [diff] [review]
Patch

Nom for aurora. Fixes a bug in how we calculate the velocity. Can lead to issues with panning. Mobile only.
Attachment #591226 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f8282085e225
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

Updated

6 years ago
Attachment #591226 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/02093039f454
status-firefox11: --- → fixed
status-firefox12: --- → fixed
You need to log in before you can comment on or make changes to this bug.