711177 - Form autocomplete popup doesn't appear on tap of input

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the input, type 'abc' and submit the form
- Tap on the input again

Expected result:
A form autocomplete popup should appear with the entry 'abc' inside it.

Actual result:
No form autocomplete popup

Comment 2

[:Margaret Leibovic]

This looks like a different issue than the one we ended up discussing in bug 711096. That bug was about showing identical matching results, and this bug is about showing results for an empty input box when you tap on it.

I think we should consider showing results for an empty input box to give the user the opportunity to avoid using the keyboard.

Comment 3

[Madhava Enros [:madhava]]

Yes - I think I agree with Margaret in Comment 2.

Comment 4

[:Margaret Leibovic]

Attachment: patch

This patch prioritizes a validation message over an autocomplete suggestion in the focus case, which is the opposite of how we handle the input case. I did this because that's what XUL fennec does. Also, I think that makes sense, since the form validation message will only be available if an invalid form was submitted, and in that case, the user is probably like "Hm, why was my input wrong?" more than "Hey, give me some suggestions!"

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 603445 [details] [diff] [review]
patch

Review of attachment 603445 [details] [diff] [review]:
-----------------------------------------------------------------

Good.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a19bd82cb53

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a19bd82cb53

Comment 8

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Tab 2 7.0
-OS: Android 4.0.4