711184 - make sure we don't do any work creating about:home if we're not showing about:home

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Brad Lassey [:blassey] (use needinfo?)]

the OS constructs the about:home content even if we're not showing it, I want to confirm that we're not hitting the history and bookmark DBs when we're not showing about:home because we're launched with a URI

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

this makes sure we don't hit the DBs if we're not showing about:home

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 582372 [details] [diff] [review]
patch

Review of attachment 582372 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AboutHomeContent.java
@@ +169,2 @@
>          GeckoAppShell.getHandler().post(new Runnable() {
>              public void run() {

Is the spacing off between inflater.* and GeckoAppShell

::: mobile/android/base/GeckoApp.java
@@ +977,4 @@
>  
>          public void run() {
>              mAutoCompletePopup.hide();
> +            if (mAboutHomeContent == null && mShow) {

Do you need the mShow test here?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

> >  
> >          public void run() {
> >              mAutoCompletePopup.hide();
> > +            if (mAboutHomeContent == null && mShow) {
> 
> Do you need the mShow test here?
That's the part that keeps us from constructing the about:home view until its going to be shown

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/434e5060c706

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/434e5060c706

Comment 7

[Doug Turner (:dougt)]

brad, this crashes on ICS.  I backed it out.

https://hg.mozilla.org/mozilla-central/rev/a5e63e00db27

Comment 8

[Doug Turner (:dougt)]

ine 185 mTopSitesGrid is null.  not sure if onFinishInflate is being called.  only ics.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/3f050eb4f8ac

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/6d281a8799fb

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

turns out there are two gecko_app.xml's now. Fixed and re-landed on inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/feaccb6a4c35

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/feaccb6a4c35