make sure we don't do any work creating about:home if we're not showing about:home

RESOLVED FIXED

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 2 obsolete attachments)

the OS constructs the about:home content even if we're not showing it, I want to confirm that we're not hitting the history and bookmark DBs when we're not showing about:home because we're launched with a URI
Created attachment 582291 [details] [diff] [review]
patch

this makes sure we don't hit the DBs if we're not showing about:home
Assignee: nobody → blassey.bugs
Attachment #582291 - Flags: review?(doug.turner)
Created attachment 582372 [details] [diff] [review]
patch
Attachment #582291 - Attachment is obsolete: true
Attachment #582291 - Flags: review?(doug.turner)
Attachment #582372 - Flags: review?(doug.turner)

Comment 3

6 years ago
Comment on attachment 582372 [details] [diff] [review]
patch

Review of attachment 582372 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AboutHomeContent.java
@@ +169,2 @@
>          GeckoAppShell.getHandler().post(new Runnable() {
>              public void run() {

Is the spacing off between inflater.* and GeckoAppShell

::: mobile/android/base/GeckoApp.java
@@ +977,4 @@
>  
>          public void run() {
>              mAutoCompletePopup.hide();
> +            if (mAboutHomeContent == null && mShow) {

Do you need the mShow test here?
Attachment #582372 - Flags: review?(doug.turner) → review+
> >  
> >          public void run() {
> >              mAutoCompletePopup.hide();
> > +            if (mAboutHomeContent == null && mShow) {
> 
> Do you need the mShow test here?
That's the part that keeps us from constructing the about:home view until its going to be shown
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/434e5060c706
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/434e5060c706
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Blocks: 707326

Comment 7

6 years ago
brad, this crashes on ICS.  I backed it out.

https://hg.mozilla.org/mozilla-central/rev/a5e63e00db27
No longer blocks: 707326
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 8

6 years ago
ine 185 mTopSitesGrid is null.  not sure if onFinishInflate is being called.  only ics.
(Assignee)

Updated

6 years ago
Priority: -- → P2
Created attachment 583059 [details] [diff] [review]
patch
Attachment #582372 - Attachment is obsolete: true
Attachment #583059 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #583059 - Flags: review?(doug.turner) → review+
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/3f050eb4f8ac
Whiteboard: [inbound]
backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/6d281a8799fb
turns out there are two gecko_app.xml's now. Fixed and re-landed on inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/feaccb6a4c35
https://hg.mozilla.org/mozilla-central/rev/feaccb6a4c35
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
tracking-fennec: --- → 11+
(Assignee)

Updated

6 years ago
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.