711216 - Form autocomplete popup doesn't disappear when input gets out of view after pinch zoom

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Martijn Wargers (dead)]

- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the input, type 'abc' and submit the form
- Tap on the input again
- Type 'a' -> form autocomplete popup appears with 'abc' in it
- Now pinch zoom the page in such a way that the input gets out of view

Expected result:
- Form autocomplete popup should disappear when the input gets out of view

Actual result:
- Form autocomplete popup stays visible

Comment 3

[:Margaret Leibovic]

Attachment: patch

This just hides the popup whenever we zoom. Should we try to re-show it after zooming?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Margaret Leibovic [:margaret] from comment #3)

> Should we try to re-show it after zooming?

I don't think we should.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583684 [details] [diff] [review]
patch

We should have this cleanup on aurora

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 583684 [details] [diff] [review]
patch

[Triage Comment]
Let's land this on Aurora after we take it on m-c. Shortcutting normal process here because of where we are in the cycle and the straightforwardness of the patch.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7416f66e61f

will land on aurora once this hits m-c

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c7416f66e61f

Comment 9

[Carla Nadastean]

Verified with:
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111229 Firefox/12.0a1
Fennec/12.0a1
HTC Desire Z (Android 2.3)

Form autocomplete popup disappears when the input gets out of view.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d7edd256258f