711309 - Can't create complete MAR using signed win32 exe file

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Rail Aliiev [:rail]]

Error:

===============================================================
make: Entering directory `/e/builds/moz2_slave/rel-m-rel-w32-bld/build/obj-firefox/tools/update-packaging'
test -f "/e/builds/moz2_slave/rel-m-rel-w32-bld/build/obj-firefox/tools/update-packaging/../../dist/win32/en-US/Firefox Setup 9.0.exe"
rm -f -rf "../../dist/firefox"
cd ../../dist &&  7z x "/e/builds/moz2_slave/rel-m-rel-w32-bld/build/obj-firefox/tools/update-packaging/../../dist/win32/en-US/Firefox Setup 9.0.exe" core && mv core firefox

7-Zip 4.65  Copyright (c) 1999-2009 Igor Pavlov  2009-02-03

Processing archive: e:\builds\moz2_slave\rel-m-rel-w32-bld\build\obj-firefox\tools\update-packaging\..\..\dist\win32\en-US\Firefox Setup 9.0.exe


No files to process

Files: 0
Size:       0
Compressed: 15949040
mv: cannot stat `core': No such file or directory
make: Leaving directory `/e/builds/moz2_slave/rel-m-rel-w32-bld/build/obj-firefox/tools/update-packaging'
make: *** [complete-patch] Error 1

===============================================================

I suspect that 7zip can't extract the file properly:

===============================================================
$ 7z l "Firefox Setup 9.0.exe"

7-Zip 4.65  Copyright (c) 1999-2009 Igor Pavlov  2009-02-03

Listing archive: Firefox Setup 9.0.exe

CPU = x86
Characteristics = Executable 32-bit NoRelocs NoLineNums NoLocalSyms
Created = 2006-08-15 14:27:50
Physical Size = 15946816
Headers Size = 4096
Checksum = 0
Image Size = 167936
Section Alignment = 4096
File Alignment = 512
Code Size = 40960
Initialized Data Size = 28672
Uninitialized Data Size = 94208
Linker Version = 6.0
OS Version = 4.0
Image Version = 0.0
Subsystem Version = 4.0
Subsystem = Windows GUI
Stack Reserve = 1048576
Stack Commit = 4096
Heap Reserve = 1048576
Heap Commit = 4096

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2006-08-15 14:27:50              94208            0  UPX0
2006-08-15 14:27:50              40960        40960  UPX1
2006-08-15 14:27:50              28672        28160  .rsrc
2006-08-15 14:27:50               3512         3512  CERTIFICATE
------------------- ----- ------------ ------------  ------------------------
                                167352        72632  4 files, 0 folders
===============================================================

However, 7zip 9.20 unpacks it properly:

===============================================================
$ 7z l "Firefox Setup 9.0.exe"
7-Zip (A) 9.20  Copyright (c) 1999-2010 Igor Pavlov  2010-11-18

Listing archive: Firefox Setup 9.0.exe

--
Path = Firefox Setup 9.0.exe
Type = 7z
Method = LZMA BCJ2
Solid = +
Blocks = 1
Physical Size = 15873073
Headers Size = 1471
Offset = 70225

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2011-12-15 16:51:45 ....A         1599     15871602  core\precomplete
2011-12-15 15:14:09 ....A        35403               core\removed-files
2011-12-15 16:51:21 ....A         2185               core\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}\icon.png
2011-12-15 16:51:21 ....A         9303               core\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}\preview.png
2011-12-15 16:51:38 ....A           34               core\components\binary.manifest
2011-12-15 16:51:43 ....A           36               core\chrome.manifest
2011-12-15 16:51:20 ....A         1869               core\Microsoft.VC80.CRT.manifest
2011-12-15 16:51:19 ....A         1394               core\searchplugins\amazondotcom.xml
2011-12-15 16:51:19 ....A         2252               core\searchplugins\bing.xml
2011-12-15 16:51:20 ....A        12108               core\blocklist.xml
................

===============================================================


Need to check nightlies as well.

Comment 1

[Rail Aliiev [:rail]]

Just checked latest nightly build. Everything looks fine and we use  7-zip 4.42 there. I tried to unpack the last nightly file with 4.65 and 4.42 and it worked with 4.42 but not 4.65.

I believe that 7-zip 4.65 is from bug 594474.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Rail Aliiev [:rail] from comment #1)
> Just checked latest nightly build. Everything looks fine and we use  7-zip
> 4.42 there. I tried to unpack the last nightly file with 4.65 and 4.42 and
> it worked with 4.42 but not 4.65.
> 
> I believe that 7-zip 4.65 is from bug 594474.

7-Zip has an updated version (9.20) at http://www.7-zip.org/

Bug 409455 updated the version from 4.42 to 4.65 in MozillaBuild.

Comment 3

[(not currently active) Ted Mielczarek]

This is why we can't have nice things. :-( (more to the point, this is why we don't like to update things in MozillaBuild unless there's a pressing need)

Comment 4

[Rail Aliiev [:rail]]

Closing since bug 594474 WONTFIXED