DisableFontActivation is incorrectly releasing CF objects it doesn't own

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 582206 [details] [diff] [review]
don't CFRelease objects when we don't have an owning reference

See static analysis reports:
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-0VgVPA.html#EndPath
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-GiQGwa.html#EndPath

The Core Foundation "Get" APIs don't return an owning reference, so we shouldn't be releasing these objects.
Attachment #582206 - Flags: review?(jdaggett)

Updated

6 years ago
Attachment #582206 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 1

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f609b9104c
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e0f609b9104c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 712350
You need to log in before you can comment on or make changes to this bug.