Closed Bug 711352 Opened 12 years ago Closed 12 years ago

DisableFontActivation is incorrectly releasing CF objects it doesn't own

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

don't CFRelease objects when we don't have an owning reference
949 bytes, patch
jtd
: review+
Details | Diff | Splinter Review 
See static analysis reports:
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-0VgVPA.html#EndPath
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-GiQGwa.html#EndPath

The Core Foundation "Get" APIs don't return an owning reference, so we shouldn't be releasing these objects.
Attachment #582206 - Flags: review?(jdaggett)
Attachment #582206 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/e0f609b9104c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.