Last Comment Bug 711352 - DisableFontActivation is incorrectly releasing CF objects it doesn't own
: DisableFontActivation is incorrectly releasing CF objects it doesn't own
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Jonathan Kew (:jfkthame)
:
Mentors:
Depends on:
Blocks: clang-analysis 711301
  Show dependency treegraph
 
Reported: 2011-12-16 01:40 PST by Jonathan Kew (:jfkthame)
Modified: 2011-12-20 09:58 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
don't CFRelease objects when we don't have an owning reference (949 bytes, patch)
2011-12-16 01:40 PST, Jonathan Kew (:jfkthame)
jd.bugzilla: review+
Details | Diff | Splinter Review

Description Jonathan Kew (:jfkthame) 2011-12-16 01:40:01 PST
Created attachment 582206 [details] [diff] [review]
don't CFRelease objects when we don't have an owning reference

See static analysis reports:
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-0VgVPA.html#EndPath
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-GiQGwa.html#EndPath

The Core Foundation "Get" APIs don't return an owning reference, so we shouldn't be releasing these objects.
Comment 2 Marco Bonardo [::mak] 2011-12-19 08:37:49 PST
https://hg.mozilla.org/mozilla-central/rev/e0f609b9104c

Note You need to log in before you can comment on or make changes to this bug.